Skip to contentSkip to conversation

i2c: make i2c-isa drivers inherits

PATCH In review Laurent Riffard 2 participants 3 messages Sep 30, 2005 – Oct 1, 2005

lore
Share & tools
lore
#0 lore raw

PATCH 5/5 i2c: make i2c-isa drivers inherits

In function i2c_isa_add_driver, copied driver should inherit the owner field as well as the name field.

---

Index: linux-2.6-mm/drivers/i2c/busses/i2c-isa.c
=================================--- linux-2.6-mm.orig/drivers/i2c/busses/i2c-isa.c 2005-09-30 16:27:50.000000000 +0200
+++ linux-2.6-mm/drivers/i2c/busses/i2c-isa.c 2005-09-30 16:34:00.903153000 +0200
@@ -92,6 +92,7 @@

        /* Add the driver to the list of i2c drivers in the driver core */
        driver->driver.name = driver->name;
+       driver->driver.owner = driver->owner;
        driver->driver.bus = &i2c_bus_type;
        driver->driver.probe = i2c_isa_device_probe;
        driver->driver.remove = i2c_isa_device_remove;

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 252 bytes
Desc: OpenPGP digital signature
Url : http://lists.lm-sensors.org/pipermail/lm-sensors/attachments/20050930/d6b71bde/signature.bin

#1 lore raw

[lm-sensors] Re: [PATCH 2.6-mm 5/5] i2c: make i2c-isa drivers

Hi Laurent,

Quoted 13 lines

In function i2c_isa_add_driver, copied driver should inherit the owner field as well as the name field.

---

Index: linux-2.6-mm/drivers/i2c/busses/i2c-isa.c
=================================> --- linux-2.6-mm.orig/drivers/i2c/busses/i2c-isa.c 2005-09-30 16:27:50.000000000 +0200
+++ linux-2.6-mm/drivers/i2c/busses/i2c-isa.c 2005-09-30 16:34:00.903153000 +0200

Review line 98

Quoted 7 lines
(quoted diff) +1 -0
@@ -92,6 +92,7 @@
 
        /* Add the driver to the list of i2c drivers in the driver core */
        driver->driver.name = driver->name;
+       driver->driver.owner = driver->owner;
        driver->driver.bus = &i2c_bus_type;
        driver->driver.probe = i2c_isa_device_probe;
        driver->driver.remove = i2c_isa_device_remove;

This one doesn't apply, because of tabs/spaces conversions it seems. Please resend in a suitable form.

BTW, I appreciate diffstat output in the patch headers, it helps figuring out at a glance which files a patch affects and how.

Thanks,

Signature · 1 line
Jean Delvare
#2 lore raw

[lm-sensors] Re: [PATCH 2.6-mm 5/5] i2c: make i2c-isa drivers

In reply to Laurent Riffard

Le 01.10.2005 21:49, Jean Delvare a ?crit :

Quoted 9 lines

Hi Laurent,

Quoted 7 lines

In function i2c_isa_add_driver, copied driver should inherit the owner field as well as the name field.

---

[snip]

Quoted 8 lines

This one doesn't apply, because of tabs/spaces conversions it seems. Please resend in a suitable form.

BTW, I appreciate diffstat output in the patch headers, it helps figuring out at a glance which files a patch affects and how.

Thanks,

Oops ! Sorry about that... here is an updated version:

---
In function i2c_isa_add_driver, copied driver should inherit the owner field as well as the name field.

---

 i2c-isa.c |    1 +
 1 files changed, 1 insertion(+)

Index: linux-2.6-mm/drivers/i2c/busses/i2c-isa.c
=================================--- linux-2.6-mm.orig/drivers/i2c/busses/i2c-isa.c 2005-09-09 23:39:50.000000000 +0200
+++ linux-2.6-mm/drivers/i2c/busses/i2c-isa.c 2005-09-10 10:55:14.425721250 +0200
@@ -92,6 +92,7 @@

/* Add the driver to the list of i2c drivers in the driver core */ driver->driver.name = driver->name;
+ driver->driver.owner = driver->owner;
driver->driver.bus = &i2c_bus_type; driver->driver.probe = i2c_isa_device_probe; driver->driver.remove = i2c_isa_device_remove;

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 252 bytes
Desc: OpenPGP digital signature
Url : http://lists.lm-sensors.org/pipermail/lm-sensors/attachments/20051001/55d9e139/signature.bin