Skip to contentSkip to conversation

fix ipv6 fragment ID selection at slow path

PATCH In review Yan Zheng 2 participants 2 messages Oct 2, 2005 – Oct 3, 2005

Subsystems (3)
Networking Network drivers IPv4/IPv6
lore
Share & tools
lore

Yan Zheng

author
#0 lore raw

PATCH 1/1 fix ipv6 fragment ID selection at slow path

net/ipv6/ip6_output.c +1 -1
@@ -701,7 +701,7 @@
 		 */
 		fh->nexthdr = nexthdr;
 		fh->reserved = 0;
-		if (frag_id) {
+		if (!frag_id) {
 			ipv6_select_ident(skb, fh);
 			frag_id = fh->identification;
 		} else
#1 lore raw

net/ipv6/ip6_output.c 2005-10-02 22:12:54.000000000 +0800 line 707

Quoted 12 lines · Yan Zheng
net/ipv6/ip6_output.c 2005-10-02 22:12:54.000000000 +0800 renamed from net/ipv6/ip6_output.c 2005-09-17 09:02:12.000000000 +0800 +1 -1
@@ -701,7 +701,7 @@
                */
               fh->nexthdr = nexthdr;
               fh->reserved = 0;
-               if (frag_id) {
+               if (!frag_id) {
                       ipv6_select_ident(skb, fh);
                       frag_id = fh->identification;
               } else

This patch makes sense to me.

Please add a Signed-off-by line and send the patch to [email protected] and [email protected].

Thanks,

Signature · 4 lines
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt