Skip to contentSkip to conversation

IPW Question on menuconfig

PATCH New Alejandro Bonilla Beeche 3 participants 4 messages Oct 11, 2005 – Nov 13, 2005

Subsystems (3)
Networking Network drivers Networking drivers (wireless)
lore
Share & tools
lore

Alejandro Bonilla Beeche

author
#0 lore raw

Hi,

I was just git updating 2.6.14-rc4 and I didn't have the
CONFIG_IEEE80211 module selected, then I went into Device Drivers / Network devices / Wireless, and the IPW2100 wasn't in the list. I went, then Modularized the IEEE80211 and then IPW2100 was there. I think is kind of estrange that IPW2100 wouldn't show just because it has a dependencie, shouldn't IPW2100 show in the list, and if you select it, then it would also select CONFIG_IEEE80211?

Just a dumb question cause I dunno how is normally done or the policy to do this.

.Alejandro

#1 lore raw
Quoted 5 lines · Alejandro Bonilla Beeche

Network devices / Wireless, and the IPW2100 wasn't in the list. I went, then Modularized the IEEE80211 and then IPW2100 was there. I think is kind of estrange that IPW2100 wouldn't show just because it has a dependencie, shouldn't IPW2100 show in the list, and if you select it, then it would also select CONFIG_IEEE80211?

I think you are right, so the config script should be changed like shown below. (But I'm not really familiar with the config language, so I may be missing some obvious problems?)

Signed-off-by Jan Niehusmann <[email protected]>

(in case somebody cares for that for such a small change...)

drivers/net/wireless/Kconfig +4 -2
@@ -139,8 +139,9 @@ comment "Wireless 802.11b ISA/PCI cards 
 
 config IPW2100
 	tristate "Intel PRO/Wireless 2100 Network Connection"
-	depends on NET_RADIO && PCI && IEEE80211
+	depends on NET_RADIO && PCI
 	select FW_LOADER
+	select IEEE80211
 	---help---
           A driver for the Intel PRO/Wireless 2100 Network 
 	  Connection 802.11b wireless network adapter.

@@ -192,8 +193,9 @@ config IPW_DEBUG
 
 config IPW2200
 	tristate "Intel PRO/Wireless 2200BG and 2915ABG Network Connection"
-	depends on IEEE80211 && PCI
+	depends on PCI
 	select FW_LOADER
+	select IEEE80211
 	---help---
           A driver for the Intel PRO/Wireless 2200BG and 2915ABG Network
 	  Connection adapters.
#2 lore raw

Do we want this patch? If yes, Jan could you reformat your posting according to the rules described here:

http://linux.yyz.us/patch-format.html

Please pay particular attention to formatting your subject and changelog information.

Thanks,

John

Quoted 45 lines · Jan Niehusmann
Quoted 5 lines · Alejandro Bonilla Beeche

Network devices / Wireless, and the IPW2100 wasn't in the list. I went, then Modularized the IEEE80211 and then IPW2100 was there. I think is kind of estrange that IPW2100 wouldn't show just because it has a dependencie, shouldn't IPW2100 show in the list, and if you select it, then it would also select CONFIG_IEEE80211?

I think you are right, so the config script should be changed like shown below. (But I'm not really familiar with the config language, so I may be missing some obvious problems?)

Signed-off-by Jan Niehusmann <[email protected]>

(in case somebody cares for that for such a small change...)

drivers/net/wireless/Kconfig +4 -3
@@ -139,8 +139,9 @@ comment "Wireless 802.11b ISA/PCI cards 
 
 config IPW2100
 	tristate "Intel PRO/Wireless 2100 Network Connection"
-	depends on NET_RADIO && PCI && IEEE80211
+	depends on NET_RADIO && PCI
 	select FW_LOADER
+	select IEEE80211
 	---help---
           A driver for the Intel PRO/Wireless 2100 Network 
 	  Connection 802.11b wireless network adapter.

@@ -192,8 +193,9 @@ config IPW_DEBUG
 
 config IPW2200
 	tristate "Intel PRO/Wireless 2200BG and 2915ABG Network Connection"
-	depends on IEEE80211 && PCI
+	depends on PCI
 	select FW_LOADER
+	select IEEE80211
 	---help---
           A driver for the Intel PRO/Wireless 2200BG and 2915ABG Network
 	  Connection adapters. 
 
-

To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Signature · 2 lines
John W. Linville
[email protected]
#3 lore raw

PATCH 1/1 IPW2100/2200: Question on menuconfig

In reply to Alejandro Bonilla Beeche

This patch makes the IPW2100 and IPW2200 options available in the configuration menu even if IEEE80211 has not been selected before. This behaviour is more intuitive for people which are not familiar with the driver internals.
The suggestion for this change was made by Alejandro Bonilla Beeche.

Signed-off-by Jan Niehusmann <[email protected]>
drivers/net/wireless/Kconfig +4 -2
@@ -139,8 +139,9 @@ comment "Wireless 802.11b ISA/PCI cards 
 
 config IPW2100
 	tristate "Intel PRO/Wireless 2100 Network Connection"
-	depends on NET_RADIO && PCI && IEEE80211
+	depends on NET_RADIO && PCI
 	select FW_LOADER
+	select IEEE80211
 	---help---
           A driver for the Intel PRO/Wireless 2100 Network 
 	  Connection 802.11b wireless network adapter.

@@ -192,8 +193,9 @@ config IPW_DEBUG
 
 config IPW2200
 	tristate "Intel PRO/Wireless 2200BG and 2915ABG Network Connection"
-	depends on IEEE80211 && PCI
+	depends on PCI
 	select FW_LOADER
+	select IEEE80211
 	---help---
           A driver for the Intel PRO/Wireless 2200BG and 2915ABG Network
 	  Connection adapters.