scsi: advansys needs ISA dma api for ISA support
PATCH v2 1/1 scsi: advansys needs ISA dma api for ISA support
The advansys drvier uses the request_dma function that is used on ISA machines for the internal DMA controller, which causes build errors on platforms that have ISA slots but do not provide the ISA DMA API:
drivers/scsi/advansys.c: In function 'advansys_board_found':drivers/scsi/advansys.c:11300:10: error: implicit declaration of function 'request_dma' [-Werror=implicit-function-declaration]
The problem now showed up in ARM randconfig builds after commit 6571fb3f8b7f ("advansys: Update to version 3.5 and remove compilation warning") made it possible to build on platforms that have neither VIRT_TO_BUS nor ISA_DMA_API but that do have ISA.
This adds a dependency to only build the driver on ISA based machines if they also support ISA_DMA_API, or if they EISA or PCI are also enabled.
drivers/scsi/Kconfig +1 -1
@@ -498,7 +498,7 @@ config SCSI_DPT_I2O config SCSI_ADVANSYS tristate "AdvanSys SCSI support" depends on SCSI - depends on ISA || EISA || PCI + depends on (ISA && ISA_DMA_API) || EISA || PCI help This is a driver for all SCSI host adapters manufactured by AdvanSys. It is documented in the kernel source in
Quoted 12 lines · Arnd Bergmann
The advansys drvier uses the
request_dmafunction that is used on ISA machines for the internal DMA controller, which causes build errors on platforms that have ISA slots but do not provide the ISA DMA API:
drivers/scsi/advansys.c: In function 'advansys_board_found':drivers/scsi/advansys.c:11300:10: error: implicit declaration of function 'request_dma' [-Werror=implicit-function-declaration]The problem now showed up in ARM randconfig builds after commit
6571fb3f8b7f("advansys: Update to version 3.5 and remove compilation warning") made it possible to build on platforms that have neitherVIRT_TO_BUSnorISA_DMA_APIbut that do have ISA.
Quoted 6 lines
This adds a dependency to only build the driver on ISA based machines if they also support
ISA_DMA_API, or if they EISA or PCI are also enabled.Signed-off-by Arnd Bergmann <[email protected]>
Cheers,
Hannes
Signature · 5 lines
Dr. Hannes Reinecke zSeries & Storage hare at suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N?rnberg GF: F. Imend?rffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG N?rnberg)
James Bottomley
maintainerQuoted 23 lines · Arnd Bergmann
The advansys drvier uses the
request_dmafunction that is used on ISA machines for the internal DMA controller, which causes build errors on platforms that have ISA slots but do not provide the ISA DMA API:
drivers/scsi/advansys.c: In function 'advansys_board_found':drivers/scsi/advansys.c:11300:10: error: implicit declaration of function 'request_dma' [-Werror=implicit-function-declaration]The problem now showed up in ARM randconfig builds after commit
6571fb3f8b7f("advansys: Update to version 3.5 and remove compilation warning") made it possible to build on platforms that have neitherVIRT_TO_BUSnorISA_DMA_APIbut that do have ISA.This adds a dependency to only build the driver on ISA based machines if they also support
ISA_DMA_API, or if they EISA or PCI are also enabled.Signed-off-by Arnd Bergmann <[email protected]>drivers/scsi/Kconfig +0
-0
drivers/scsi/Kconfig config SCSI_DPT_I2O · line 501
Quoted 5 lines
drivers/scsi/Kconfig +1
-1@@ -498,7 +498,7 @@ config SCSI_DPT_I2O config SCSI_ADVANSYS tristate "AdvanSys SCSI support" depends on SCSI - depends on ISA || EISA || PCI + depends on (ISA && ISA_DMA_API) || EISA || PCI
I thought the desire was to avoid a compile failure when ISA && ! ISA_DMA_API? Won't this one fail if ISA is defined with either EISA or PCI and !ISA_DMA_API?
James
Quoted 17 lines · On Friday 16 October 2015 06:53:44 James Bottomley wrote:
drivers/scsi/Kconfig config SCSI_DPT_I2O · line 501
Quoted 13 lines
Signed-off-by Arnd Bergmann <[email protected]>drivers/scsi/Kconfig +1
-1@@ -498,7 +498,7 @@ config SCSI_DPT_I2O config SCSI_ADVANSYS tristate "AdvanSys SCSI support" depends on SCSI - depends on ISA || EISA || PCI + depends on (ISA && ISA_DMA_API) || EISA || PCII thought the desire was to avoid a compile failure when ISA && !
ISA_DMA_API? Won't this one fail if ISA is defined with either EISA or PCI and !ISA_DMA_API?
I thought I had it ruled out, but now I've actually found a combination:
we can build an ARM kernel that supports two ancient machines, and one of them supports ISA (but not ISA_DMA_API), while the other one supports PCI. I had looked through several thousand randconfig builds and not found this combination together with advansys, but I guess that is because those were mostly old builds from the times when there was a dependency on VIRT_TO_BUS that this platform doesn't have.
So screw this one and go back to the original patch.
Arnd
James Bottomley
maintainerQuoted 27 lines · Arnd Bergmann
Quoted 17 lines · On Friday 16 October 2015 06:53:44 James Bottomley wrote:
drivers/scsi/Kconfig config SCSI_DPT_I2O · line 501
Quoted 13 lines
Signed-off-by Arnd Bergmann <[email protected]>drivers/scsi/Kconfig +1
-1@@ -498,7 +498,7 @@ config SCSI_DPT_I2O config SCSI_ADVANSYS tristate "AdvanSys SCSI support" depends on SCSI - depends on ISA || EISA || PCI + depends on (ISA && ISA_DMA_API) || EISA || PCII thought the desire was to avoid a compile failure when ISA && !
ISA_DMA_API? Won't this one fail if ISA is defined with either EISA or PCI and !ISA_DMA_API?I thought I had it ruled out, but now I've actually found a combination:
we can build an ARM kernel that supports two ancient machines, and one of them supports ISA (but notISA_DMA_API), while the other one supports PCI. I had looked through several thousand randconfig builds and not found this combination together with advansys, but I guess that is because those were mostly old builds from the times when there was a dependency onVIRT_TO_BUSthat this platform doesn't have.
Quoted 1 line
So screw this one and go back to the original patch.
Agreed ... you've also got PA-RISC that enables EISA and is ! DMA_ISA_API.
James