Skip to contentSkip to conversation

fix vgacon blanking

PATCH Bodo Eggert 3 participants 3 messages Oct 20, 2005 – Oct 21, 2005 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw
Quoted 5 lines · Pozsar Balazs

This patch fixes a long-standing vgacon bug: characters with the bright bit set were left on the screen and not blacked out.
All I did was that I lookuped up some examples on the net about setting the vga palette, and added the call missing from the linux kernel, but included in all other ones. It works for me.

This is strange, since according to my documentation, the value should have been initialized to 0xff and never been changed. Can you test setting this value during initialisation (around line 259, if I read correctly) instead? I don't know if I can test it myself soon enough.

(I'm not the maintainer, I just happen to have some documentation).

Signature · 2 lines
Ich danke GMX dafür, die Verwendung meiner Adressen mittels per SPF
verbreiteten Lügen zu sabotieren.
#2 lore raw
Quoted 8 lines · Bodo Eggert
Quoted 5 lines · Pozsar Balazs

This patch fixes a long-standing vgacon bug: characters with the bright bit set were left on the screen and not blacked out.
All I did was that I lookuped up some examples on the net about setting the vga palette, and added the call missing from the linux kernel, but included in all other ones. It works for me.

Quoted 6 lines

This is strange, since according to my documentation, the value should have been initialized to 0xff and never been changed. Can you test setting this value during initialisation (around line 259, if I read correctly) instead? I don't know if I can test it myself soon enough.

(I'm not the maintainer, I just happen to have some documentation).

Maybe I can test it tomorrow. But as the posted patch work as-is, cannot do any harm because it just makes sure the register is set as it should be, and we are talking about a not-so-often called slowpath, I think it should just be merged and get forgotten, without making a big hassle making around it :)
On the other side, as this bug is a little annoyment, it can be tested in -mm until 2.6.15 or so. I have the cure now, so I'm happy with it :)

Signature · 1 line
pozsy
#3 lore raw
In reply to Bodo Eggert
Quoted 8 lines · Bodo Eggert
Quoted 5 lines · Pozsar Balazs

This patch fixes a long-standing vgacon bug: characters with the bright bit set were left on the screen and not blacked out.
All I did was that I lookuped up some examples on the net about setting the vga palette, and added the call missing from the linux kernel, but included in all other ones. It works for me.

Quoted 4 lines

This is strange, since according to my documentation, the value should have been initialized to 0xff and never been changed. Can you test setting this value during initialisation (around line 259, if I read correctly) instead? I don't know if I can test it myself soon enough.

Actually, I don't see the palette mask (0x3c6) set anywhere in vgacon. The code in line 259 sets the first 16 entries of the internal palette (0x3c0: 0x0-0xf) so it points to the first 16 entries of the DAC.

Tony