kconfig and lxdialog, kernel 2.6.13.4

Hello group,

The overall purpose of this patch is to add an "Abort" button to the exit dialog of "make menuconfig" (kconfig), which returns the user to the root menu if he/she chooses the Abort button (useful if the user didn't actually want to exit kconfig). kconfig relies on lxdialog to display the exit dialog. As a result, most functionality changes were made to lxdialog.

I have read MAINTAINERS and was unable to locate any maintainer for lxdialog. Please feel free to let me know who should have been included on this message and I apologize ahead of time for leaving you out.

This is my first submission to the LKML so please feel free to provide me with any feedback before I submit the patches to Linus.

I hope I haven't shot myself in the foot; but, (and please no offense to the original author(s)) I was almost totally unable to follow the original style from the lxdialog source code (e.g. new blocks were spaced two spaces to the left rather than the style I've become accustomed to, spacing to the right). Basically, I ended up running Lindent against the source in scripts/lxdialog/ and [naturally] I've now made the patch much larger than it should have been (next time I'll read the FAQ *before* I start writing a patch and hence the reason I'm posting the first patch as a URL). Hopefully, by submitting the format changes first, it will be clear what the important modifications were. In other words, the first patch is *only* a format change. The next two patches will be the important functionality modifications to lxdialog and kconfig.

http://www2.capitalgenomix.com/temp/linux_patch/format_patch

Sean

Hi,

Looks fine, but you could also please manually cleanup the parts which got too much indented to the right. Usually one tries to move them into separate functions, but sometimes exceeding the 80 char limit is IMO fine too.

bye, Roman

Hi Roman,

Thank you for all of your feedback. It is much appreciated. Also, I apologize for not getting back to you sooner; I got held up on a lot of stuff at work.

Here is an updated patch for the updated 2.6.14 kernel. Please note, however, that I have not done any cleanup because I wanted to know your opinion, first. Would you rather I try to format my changes the same as the *original* lxdialog style, or include the styling changes in a separate patch and leave my formatting the way it is? I realize that it's usually against common curtesy to modify the style, so I'll take whatever advise you can give me on this.

http://www2.capitalgenomix.com/temp/linux_patch/format.patch

Sean