Skip to contentSkip to conversation

drivers/net/dgrs.c: Fix potential "unused variable"-warning.

PATCH In review Richard Knutsson 2 participants 3 messages Oct 26, 2005 – Oct 28, 2005 Network drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drivers/net/dgrs.c: Fix potential "unused variable"-warning.

Just a cosmetic change to prevent compiler-warning about unused variable (+ save 2 or 4 bytes of memory).

BTW, the authors mail-address seems invalid.

Signed-off-by Richard Knutsson

---

drivers/net/dgrs.c +0 -0
diff -uNr a/drivers/net/dgrs.c b/drivers/net/dgrs.c
@@ -1549,7 +1549,7 @@

static int __init dgrs_init_module (void)

{
	int	i;

- int eisacount = 0, pcicount = 0;
+ int count = 0;

	/*
	 *	Command line variable overrides
@@ -1591,14 +1591,14 @@
	 *	Find and configure all the cards
	 */

#ifdef CONFIG_EISA
- eisacount = eisa_driver_register(&dgrs_eisa_driver);
- if (eisacount < 0)
- return eisacount;
+ count = eisa_driver_register(&dgrs_eisa_driver);
+ if (count < 0)
+ return count;
#endif
#ifdef CONFIG_PCI
- pcicount = pci_register_driver(&dgrs_pci_driver);
- if (pcicount)
- return pcicount;
+ count = pci_register_driver(&dgrs_pci_driver);
+ if (count)
+ return count;

#endif
	return 0;
}
#1 lore raw
Quoted 12 lines · Richard Knutsson

Just a cosmetic change to prevent compiler-warning about unused variable (+ save 2 or 4 bytes of memory).

BTW, the authors mail-address seems invalid.

Signed-off-by Richard Knutsson

---

diff -uNr a/drivers/net/dgrs.c b/drivers/net/dgrs.c

drivers/net/dgrs.c 2005-10-26 15:53:43.000000000 +0200 line 1552

Quoted 5 lines
drivers/net/dgrs.c 2005-10-26 15:53:43.000000000 +0200 renamed from drivers/net/dgrs.c 2005-08-29 01:41:01.000000000 +0200 +1 -1
@@ -1549,7 +1549,7 @@
 static int __init dgrs_init_module (void)
 {
    int    i;
-    int eisacount = 0, pcicount = 0;
+    int    count = 0;

no need to initialize the variable

#2 lore raw
Quoted 14 lines · Jeff Garzik

drivers/net/dgrs.c 2005-10-26 15:53:43.000000000 +0200 line 1552

Quoted 9 lines · Richard Knutsson

diff -uNr a/drivers/net/dgrs.c b/drivers/net/dgrs.c

drivers/net/dgrs.c 2005-10-26 15:53:43.000000000 +0200 renamed from drivers/net/dgrs.c 2005-08-29 01:41:01.000000000 +0200 +1 -1
@@ -1549,7 +1549,7 @@
 static int __init dgrs_init_module (void)
 {
    int    i;
-    int eisacount = 0, pcicount = 0;
+    int    count = 0;

no need to initialize the variable

Yeah, you are right. Saw it after I sent the mail and thought it would be cluttering the mail-list just to say so. Thanks for noticing. :)

*Note to 'self:
Check and _recheck_ patch before sending it*
/Richard

PS
Sorry about the bounced mail from [email protected], did not realize it were an old address.