Skip to contentSkip to conversation

tty: serial: msm: Fix section mismatch warning

PATCH In review Kumar Gala 4 participants 7 messages Jun 3, 2014 – Jun 18, 2014

Subsystems (2)
lore
Share & tools
lore

Kumar Gala

author
#0 lore raw

PATCH 1/1 tty: serial: msm: Fix section mismatch warning

WARNING: drivers/tty/built-in.o(.data+0x3544): Section mismatch in reference from the variable msm_platform_driver to the function .init.text:msm_serial_probe()
The variable msm_platform_driver references
the function __init msm_serial_probe()
If the reference is valid then annotate the
variable with __init* or __refdata (see linux/init.h) or name the variable:
*_template, *_timer, *_sht, *_ops, *_probe, *_probe_one, *_console

---
 drivers/tty/serial/msm_serial.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/tty/serial/msm_serial.c +1 -1
index 778e376..24f3cdc 100644
@@ -991,7 +991,7 @@ static const struct of_device_id msm_uartdm_table[] = {
 	{ }
 };
 
-static int __init msm_serial_probe(struct platform_device *pdev)
+static int msm_serial_probe(struct platform_device *pdev)
 {
 	struct msm_port *msm_port;
 	struct resource *resource;
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
hosted by The Linux Foundation
maintainer
#1 lore raw
Quoted 8 lines · Kumar Gala

WARNING: drivers/tty/built-in.o(.data+0x3544): Section mismatch in reference from the variable msm_platform_driver to the function .init.text:msm_serial_probe()
The variable msm_platform_driver references
the function __init msm_serial_probe()
If the reference is valid then annotate the
variable with __init* or __refdata (see linux/init.h) or name the variable:
*_template, *_timer, *_sht, *_ops, *_probe, *_probe_one, *_console

Where is this mismatch showing up at? 3.15-rc8, 3.16-rc1? Somewhere older or else?

thanks,

greg k-h

#2 lore raw
Quoted 10 lines · Greg KH
Quoted 8 lines · Kumar Gala

WARNING: drivers/tty/built-in.o(.data+0x3544): Section mismatch in reference from the variable msm_platform_driver to the function .init.text:msm_serial_probe()
The variable msm_platform_driver references
the function __init msm_serial_probe()
If the reference is valid then annotate the
variable with __init* or __refdata (see linux/init.h) or name the variable:
*_template, *_timer, *_sht, *_ops, *_probe, *_probe_one, *_console

Quoted 2 lines

Where is this mismatch showing up at? 3.15-rc8, 3.16-rc1? Somewhere older or else?

Linus' next branch, it was merged through arm-soc. I didn't notice it in time to fix it before we sent to Linus. :(

-Olof

maintainer
#3 lore raw
Quoted 11 lines · Olof Johansson
Quoted 10 lines · Greg KH
Quoted 8 lines · Kumar Gala

WARNING: drivers/tty/built-in.o(.data+0x3544): Section mismatch in reference from the variable msm_platform_driver to the function .init.text:msm_serial_probe()
The variable msm_platform_driver references
the function __init msm_serial_probe()
If the reference is valid then annotate the
variable with __init* or __refdata (see linux/init.h) or name the variable:
*_template, *_timer, *_sht, *_ops, *_probe, *_probe_one, *_console

Quoted 5 lines
Quoted 2 lines

Where is this mismatch showing up at? 3.15-rc8, 3.16-rc1? Somewhere older or else?

Linus' next branch, it was merged through arm-soc. I didn't notice it in time to fix it before we sent to Linus. :(

Ok, do you want to take this patch then? I don't mind taking it through my tree, but it will have to wait until after 3.16-rc1 is out. It's up to you.

thanks,

greg k-h

#4 lore raw
Quoted 15 lines · Greg KH
Quoted 14 lines · Olof Johansson
Quoted 12 lines · Greg KH
Quoted 8 lines · Kumar Gala

WARNING: drivers/tty/built-in.o(.data+0x3544): Section mismatch in reference from the variable msm_platform_driver to the function .init.text:msm_serial_probe()
The variable msm_platform_driver references
the function __init msm_serial_probe()
If the reference is valid then annotate the
variable with __init* or __refdata (see linux/init.h) or name the variable:
*_template, *_timer, *_sht, *_ops, *_probe, *_probe_one, *_console

Where is this mismatch showing up at? 3.15-rc8, 3.16-rc1? Somewhere older or else?

Quoted 6 lines
Quoted 2 lines

Linus' next branch, it was merged through arm-soc. I didn't notice it in time to fix it before we sent to Linus. :(

Ok, do you want to take this patch then? I don't mind taking it through my tree, but it will have to wait until after 3.16-rc1 is out. It's up to you.

I've got a handful of fixes we're queueing for the second batch of merges, and I can add it to there.

-Olof

author
#5 lore raw
Quoted 23 lines · Olof Johansson
Quoted 15 lines · Greg KH
Quoted 14 lines · Olof Johansson
Quoted 12 lines · Greg KH
Quoted 8 lines · Kumar Gala

WARNING: drivers/tty/built-in.o(.data+0x3544): Section mismatch in reference from the variable msm_platform_driver to the function .init.text:msm_serial_probe()
The variable msm_platform_driver references
the function __init msm_serial_probe()
If the reference is valid then annotate the
variable with __init* or __refdata (see linux/init.h) or name the variable:
*_template, *_timer, *_sht, *_ops, *_probe, *_probe_one, *_console

Where is this mismatch showing up at? 3.15-rc8, 3.16-rc1? Somewhere older or else?

Quoted 6 lines
Quoted 2 lines

Linus' next branch, it was merged through arm-soc. I didn't notice it in time to fix it before we sent to Linus. :(

Ok, do you want to take this patch then? I don't mind taking it through my tree, but it will have to wait until after 3.16-rc1 is out. It's up to you.

Quoted 5 lines

I've got a handful of fixes we're queueing for the second batch of merges, and I can add it to there.

-Olof

Olof,

Reminder to queue this up for fixes for 3.16

- k

Signature · 2 lines
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
#6 lore raw
Quoted 22 lines · On Tuesday 17 June 2014 14:53:44 Kumar Gala wrote:
Quoted 19 lines · Olof Johansson
Quoted 18 lines · Greg KH
Quoted 16 lines · Olof Johansson
Quoted 10 lines · Greg KH
Quoted 8 lines · Kumar Gala

WARNING: drivers/tty/built-in.o(.data+0x3544): Section mismatch in reference from the variable msm_platform_driver to the function .init.text:msm_serial_probe()
The variable msm_platform_driver references
the function __init msm_serial_probe()
If the reference is valid then annotate the
variable with __init* or __refdata (see linux/init.h) or name the variable:
*_template, *_timer, *_sht, *_ops, *_probe, *_probe_one, *_console

Quoted 2 lines

Where is this mismatch showing up at? 3.15-rc8, 3.16-rc1? Somewhere older or else?

Linus' next branch, it was merged through arm-soc. I didn't notice it in time to fix it before we sent to Linus. :(

Quoted 8 lines
Quoted 7 lines
Quoted 3 lines

Ok, do you want to take this patch then? I don't mind taking it through my tree, but it will have to wait until after 3.16-rc1 is out. It's up to you.

I've got a handful of fixes we're queueing for the second batch of merges, and I can add it to there.

Reminder to queue this up for fixes for 3.16

I've applied it on top of the fixes branch now. I think I missed it when I picked up the other fixes as I was only looking for patches sent to arm at kernel.org.

Thanks for the reminder!

Arnd