qlogic and lpfc messaging update
PATCH 1/1 qlogic and lpfc messaging update
Gentlemen,
I would like to get these changes upstream, now that scsi-misc-2.6 has the appropriate infrastructure. These changes eliminate unneeded references to sdev->{id,channel,lun}, since the drivers' respective messaging infrastructure should already expose this.
Review requested... patch against latest scsi-misc-2.6 (a3632fa3ecefe50d88fc70af90610f79b99e0715).
Jeff
drivers/scsi/lpfc/lpfc_scsi.c +15 -24
@@ -402,10 +402,10 @@ lpfc_scsi_cmd_iocb_cmpl(struct lpfc_hba lpfc_cmd->status =IOSTAT_DEFAULT ;lpfc_printf_log (phba,KERN_WARNING ,LOG_FCP , -"%d:0729 FCP cmd x%x failed <%d/%d> status: " +"0729 FCP cmd x%x failed status: " "x%x result: x%x Data: x%x x%x\n" , - phba->brd_no, cmd->cmnd[0 ], cmd->device->id, - cmd->device->lun, lpfc_cmd->status, + cmd->cmnd[0 ], + lpfc_cmd->status, lpfc_cmd->result, pIocbOut->iocb.ulpContext, lpfc_cmd->cur_iocbq.iocb.ulpIoTag);
@@ -434,10 +434,9 @@ lpfc_scsi_cmd_iocb_cmpl(struct lpfc_hbauint32_t *lp = (uint32_t *)cmd->sense_buffer;lpfc_printf_log (phba,KERN_INFO ,LOG_FCP , -"%d:0710 Iodone <%d/%d> cmd %p, error x%x " +"0710 Iodone cmd %p, error x%x " "SNS x%x x%x Data: x%x x%x\n" , - phba->brd_no, cmd->device->id, - cmd->device->lun, cmd, cmd->result, + cmd, cmd->result, *lp, *(lp +3 ), cmd->retries, cmd->resid); }
@@ -593,10 +592,8 @@ lpfc_scsi_prep_task_mgmt_cmd(struct lpfclpfc_printf_log (phba,KERN_INFO ,LOG_FCP , -"%d:0703 Issue LUN Reset to TGT %d LUN %d " +"0703 Issue LUN Reset " "Data: x%x x%x\n" , - phba->brd_no, - scsi_dev->id, scsi_dev->lun, ndlp->nlp_rpi, ndlp->nlp_flag);break ;
@@ -605,10 +602,8 @@ lpfc_scsi_prep_task_mgmt_cmd(struct lpfclpfc_printf_log (phba,KERN_INFO ,LOG_FCP , -"%d:0701 Issue Abort Task Set to TGT %d LUN %d " +"0701 Issue Abort Task Set " "Data: x%x x%x\n" , - phba->brd_no, - scsi_dev->id, scsi_dev->lun, ndlp->nlp_rpi, ndlp->nlp_flag);break ;
@@ -617,10 +612,9 @@ lpfc_scsi_prep_task_mgmt_cmd(struct lpfclpfc_printf_log (phba,KERN_INFO ,LOG_FCP , -"%d:0702 Issue Target Reset to TGT %d " +"0702 Issue Target Reset " "Data: x%x x%x\n" , - phba->brd_no, - scsi_dev->id, ndlp->nlp_rpi, + ndlp->nlp_rpi, ndlp->nlp_flag);break ; }
@@ -837,18 +831,16 @@ __lpfc_abort_handler(struct scsi_cmnd *c ret =FAILED ;lpfc_printf_log (phba,KERN_ERR ,LOG_FCP ,"%d:0748 abort handler timed out waiting for " -"abort to complete: ret %#x, ID %d, LUN %d, " +"abort to complete: ret %#x, " "snum %#lx\n" , - phba->brd_no, ret, cmnd->device->id, - cmnd->device->lun, cmnd->serial_number); + phba->brd_no, ret, cmnd->serial_number); } out:lpfc_printf_log (phba,KERN_WARNING ,LOG_FCP ,"%d:0749 SCSI layer issued abort device: ret %#x, " -"ID %d, LUN %d, snum %#lx\n" , - phba->brd_no, ret, cmnd->device->id, - cmnd->device->lun, cmnd->serial_number); +"snum %#lx\n" , + phba->brd_no, ret, cmnd->serial_number);return ret; }
@@ -959,10 +951,9 @@ __lpfc_reset_lun_handler(struct scsi_cmn out_free_scsi_buf:lpfc_printf_log (phba,KERN_ERR ,LOG_FCP , -"%d:0713 SCSI layer issued LUN reset (%d, %d) " +"0713 SCSI layer issued LUN reset " "Data: x%x x%x x%x\n" , - phba->brd_no, lpfc_cmd->pCmd->device->id, - lpfc_cmd->pCmd->device->lun, ret, lpfc_cmd->status, + ret, lpfc_cmd->status, lpfc_cmd->result);lpfc_release_scsi_buf (phba, lpfc_cmd); out:
drivers/scsi/qla2xxx/qla_dbg.c +5 -4
@@ -1973,10 +1973,11 @@ qla2x00_print_scsi_cmd(struct scsi_cmnd ha = (struct scsi_qla_host *)cmd->device->host->hostdata; sp = (srb_t *) cmd->SCp.ptr; -printk ("SCSI Command @=0x%p, Handle=0x%p\n" , cmd, cmd->host_scribble); -printk (" chan=0x%02x, target=0x%02x, lun=0x%02x, cmd_len=0x%02x\n" , - cmd->device->channel, cmd->device->id, cmd->device->lun, - cmd->cmd_len); +scmd_printk (KERN_INFO , cmd, +"SCSI Command @=0x%p, Handle=0x%p\n" , cmd, cmd->host_scribble); +scmd_printk (KERN_INFO , cmd, +" cmd_len=0x%02x\n" , cmd->cmd_len); +printk (" CDB: " );for (i =0 ; i < cmd->cmd_len; i++) {printk ("0x%02x " , cmd->cmnd[i]);
drivers/scsi/qla2xxx/qla_isr.c +3 -4
@@ -1023,11 +1023,10 @@ qla2x00_status_entry(scsi_qla_host_t *haif ((unsigned )(cp->request_bufflen - resid) < cp->underflow) {qla_printk (KERN_INFO , ha, -"scsi(%ld:%d:%d:%d): Mid-layer underflow " +"Mid-layer underflow " "detected (%x of %x bytes)...returning " -"error status.\n" , ha->host_no, - cp->device->channel, cp->device->id, - cp->device->lun, resid, +"error status.\n" , + resid, cp->request_bufflen); cp->result =DID_ERROR <<16 ;
drivers/scsi/qla2xxx/qla_os.c +17 -27
125 lines not on this page · raw message