Skip to contentSkip to conversation

drivers/isdn/: "extern inline" -> "static inline"

PATCH In review Adrian Bunk 2 participants 2 messages Oct 30, 2005

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drivers/isdn/: "extern inline" -> "static inline"

"extern inline" doesn't make much sense.

Since there's no pullphone() function this patch removes the dead prototype.

---

 drivers/isdn/act2000/act2000.h |    6 +++---
 drivers/isdn/act2000/capi.h    |    2 +-
 drivers/isdn/sc/command.c      |    1 -
 3 files changed, 4 insertions(+), 5 deletions(-)
drivers/isdn/act2000/act2000.h renamed from drivers/isdn/act2000/act2000.h.old +3 -3
@@ -181,17 +181,17 @@
 	char regname[35];		/* Name used for request_region     */
 } act2000_card;
 
-extern __inline__ void act2000_schedule_tx(act2000_card *card)
+static inline void act2000_schedule_tx(act2000_card *card)
 {
         schedule_work(&card->snd_tq);
 }
 
-extern __inline__ void act2000_schedule_rx(act2000_card *card)
+static inline void act2000_schedule_rx(act2000_card *card)
 {
         schedule_work(&card->rcv_tq);
 }
 
-extern __inline__ void act2000_schedule_poll(act2000_card *card)
+static inline void act2000_schedule_poll(act2000_card *card)
 {
         schedule_work(&card->poll_tq);
 }
drivers/isdn/act2000/capi.h renamed from drivers/isdn/act2000/capi.h.old +1 -1
@@ -330,7 +330,7 @@
 	} msg;
 } actcapi_msg;
 
-extern __inline__ unsigned short
+static inline unsigned short
 actcapi_nextsmsg(act2000_card *card)
 {
 	unsigned long flags;
drivers/isdn/sc/command.c renamed from drivers/isdn/sc/command.c.old +0 -1
@@ -43,7 +43,6 @@
                 RspMessage *, int);
 extern int sendmessage(int, unsigned int, unsigned int, unsigned int,
                 unsigned int, unsigned int, unsigned int, unsigned int *);
-extern inline void pullphone(char *, char *);
 
 #ifdef DEBUG
 /*
#1 lore raw

Hi,

Quoted 1 line · Adrian Bunk

"extern inline" doesn't make much sense.

In fact, it does[1], but not in this particular case.

Simon

[1] "if this function is not inlined, treat it as extern instead of creating a copy in this TU".