Skip to contentSkip to conversation

dvb: Add ATSC support for DViCO FusionHDTV5 Lite

PATCH In review Michael Krufky 3 participants 4 messages Nov 1, 2005 – Nov 4, 2005 Media (V4L/DVB)

lore
Share & tools
lore

Michael Krufky

author
#0 lore raw

PATCH 4/37 dvb: Add ATSC support for DViCO FusionHDTV5 Lite

Added ATSC support for DViCO FusionHDTV5 Lite.

Signed-off-by Michael Krufky <[email protected]>
 drivers/media/dvb/bt8xx/Kconfig        |    4 +
 drivers/media/dvb/bt8xx/dvb-bt8xx.c    |   67 +++++++++++++++++++++++++++++++++
 drivers/media/dvb/bt8xx/dvb-bt8xx.h    |    1 
 drivers/media/dvb/frontends/lgdt330x.c |    1 
 4 files changed, 72 insertions(+), 1 deletion(-)
drivers/media/dvb/bt8xx/Kconfig +3 -1
@@ -6,10 +6,12 @@
 	select DVB_NXT6000
 	select DVB_CX24110
 	select DVB_OR51211
+	select DVB_LGDT330X
 	help
 	  Support for PCI cards based on the Bt8xx PCI bridge. Examples are
 	  the Nebula cards, the Pinnacle PCTV cards, the Twinhan DST cards,
-	  the pcHDTV HD2000 cards, and certain AVerMedia cards.
+	  the pcHDTV HD2000 cards, the DViCO FusionHDTV Lite cards, and
+	  some AVerMedia cards.
 
 	  Since these cards have no MPEG decoder onboard, they transmit
 	  only compressed MPEG data over the PCI bus, so you need
drivers/media/dvb/bt8xx/dvb-bt8xx.c +67 -0

91 lines not on this page · raw message

drivers/media/dvb/bt8xx/dvb-bt8xx.h +1 -0
@@ -35,6 +35,7 @@
 #include "nxt6000.h"
 #include "cx24110.h"
 #include "or51211.h"
+#include "lgdt330x.h"
 
 struct dvb_bt8xx_card {
 	struct semaphore lock;
drivers/media/dvb/frontends/lgdt330x.c +1 -0
@@ -26,6 +26,7 @@
  *   DViCO FusionHDTV 3 Gold-Q
  *   DViCO FusionHDTV 3 Gold-T
  *   DViCO FusionHDTV 5 Gold
+ *   DViCO FusionHDTV 5 Lite
  *
  * TODO:
  * signal strength always returns 0.
#1 lore raw
Quoted 4 lines · Michael Krufky

+static int tdvs_tua6034_pll_set(struct dvb_frontend* fe, struct dvb_frontend_parameters* params)
+{
+ struct dvb_bt8xx_card *card = (struct dvb_bt8xx_card *) fe->dvb->priv;

The cast of a void* is unneeded. It's actually undesirable: if someone were to convert the thing-being-casted to some other scalar type, the cast would prevent the desired compiler warning.

#2 lore raw
Quoted 4 lines · Andrew Morton
Quoted 3 lines · Michael Krufky

+static int tdvs_tua6034_pll_set(struct dvb_frontend* fe, struct dvb_frontend_parameters* params)
+{
+ struct dvb_bt8xx_card *card = (struct dvb_bt8xx_card *) fe->dvb->priv;

[cast from void *]

Please, also

	struct dvb_frontend *fe, struct dvb_frontend_parameters *params)
			   ^				       ^
author
#3 lore raw
In reply to Andrew Morton
Quoted 13 lines · Andrew Morton

drivers/media/dvb/bt8xx/dvb-bt8xx.c line 552

Quoted 5 lines · Michael Krufky
drivers/media/dvb/bt8xx/dvb-bt8xx.c +3 -0
+static int tdvs_tua6034_pll_set(struct dvb_frontend* fe, struct dvb_frontend_parameters* params)
+{
+	struct dvb_bt8xx_card *card = (struct dvb_bt8xx_card *) fe->dvb->priv;

The cast of a void* is unneeded. It's actually undesirable: if someone were to convert the thing-being-casted to some other scalar type, the cast would prevent the desired compiler warning.

Quoted 5 lines · Alexey Dobriyan

Please, also

	struct dvb_frontend *fe, struct dvb_frontend_parameters *params)
			   ^				       ^

Both of these problems are all over dvb-kernel... We'll fix it up.

Thanks,

Michael Krufky