register_filesystem() must return -EEXIST if the filesystem with the same name is already registered

If we have a look at the register_filesystem() function defined in fs/filesystems.c, we see that if a filesystem with a same name has already been registered then the find_filesystem() function will return NON-NULL otherwise it will return NULL.

Hence, register_filesystem() should return EEXIST instead of EBUSY. Returning EBUSY is misleading (unless of course I'm missing something obvious) to the caller of register_filesystem().

Thanks,

Hareesh Nagarajan

fs/filesystems.c +1 -1

@@ -76,7 +76,7 @@
 	write_lock(&file_systems_lock);
 	p = find_filesystem(fs->name);
 	if (*p)
-		res = -EBUSY;
+		res = -EEXIST;
 	else
 		*p = fs;
 	write_unlock(&file_systems_lock);

Quoted 8 lines · Hareesh Nagarajan

If we have a look at the register_filesystem() function defined in fs/filesystems.c, we see that if a filesystem with a same name has already been registered then the find_filesystem() function will return NON-NULL otherwise it will return NULL.

Hence, register_filesystem() should return EEXIST instead of EBUSY. Returning EBUSY is misleading (unless of course I'm missing something obvious) to the caller of register_filesystem().

This `slot' is buy, so EBUSY makes sense. Filesytem is not file, hence

EEXIST doesn't apply IMHO.

Coywolf

Quoted 17 lines

Thanks,

Hareesh Nagarajan

fs/filesystems.c +1 -1

@@ -76,7 +76,7 @@
 	write_lock(&file_systems_lock);
 	p = find_filesystem(fs->name);
 	if (*p)
-		res = -EBUSY;
+		res = -EEXIST;
 	else
 		*p = fs;
 	write_unlock(&file_systems_lock);

Quoted 3 lines · Hareesh Nagarajan

If we have a look at the register_filesystem() function defined in fs/filesystems.c, we see that if a filesystem with a same name has already been registered then the find_filesystem() function will return NON-NULL otherwise it will return NULL.

Hence, register_filesystem() should return EEXIST instead of EBUSY. Returning EBUSY is misleading (unless of course I'm missing something obvious) to the caller of register_filesystem().

This `slot' is buy, so EBUSY makes sense. Filesytem is not file, hence EEXIST doesn't apply IMHO.