Skip to contentSkip to conversation

fix wrong allocation flag

PATCH In review Pablo Neira 1 participant 1 message Nov 4, 2005

Subsystems (2)
Networking netfilter
lore
Share & tools
lore

Pablo Neira

author maintainer
#0 lore raw

PATCH 7/7 fix wrong allocation flag

ctnetlink_get_conntrack is always called from user context, so GFP_KERNEL is enough.

Signature · 2 lines
The dawn of the fourth age of Linux firewalling is coming; a time of
great struggle and heroic deeds -- J.Kadlecsik got inspired by J.Morris

ctnetlink_get_conntrack is always called from user context, so GFP_KERNEL is enough.

Signed-off-by Pablo Neira Ayuso <[email protected]>
net/ipv4/netfilter/ip_conntrack_netlink.c +1 -1
Index: net-2.6.git/net/ipv4/netfilter/ip_conntrack_netlink.c
===================================================================
@@ -779,7 +779,7 @@ ctnetlink_get_conntrack(struct sock *ctn
 	ct = tuplehash_to_ctrack(h);
 
 	err = -ENOMEM;
-	skb2 = alloc_skb(NLMSG_GOODSIZE, GFP_ATOMIC);
+	skb2 = alloc_skb(NLMSG_GOODSIZE, GFP_KERNEL);
 	if (!skb2) {
 		ip_conntrack_put(ct);
 		return -ENOMEM;