Skip to contentSkip to conversation

Propagate error to userspace at getting

PATCH Applied Pablo Neira 2 participants 2 messages Nov 8, 2005

Subsystems (2)
Networking netfilter
lore
Share & tools
lore

Pablo Neira

author maintainer
#0 lore raw

PATCH 2/8 Propagate error to userspace at getting

Propagate the error to userspace instead of returning -EPERM if the get conntrack operation fails.

Signed-off-by Pablo Neira Ayuso <[email protected]>
Signature · 2 lines
The dawn of the fourth age of Linux firewalling is coming; a time of
great struggle and heroic deeds -- J.Kadlecsik got inspired by J.Morris

Propagate the error to userspace instead of returning -EPERM if the get conntrack operation fails.

Signed-off-by Pablo Neira Ayuso <[email protected]>
net/ipv4/netfilter/ip_conntrack_netlink.c +1 -1
Index: netfilter-2.6.14.git/net/ipv4/netfilter/ip_conntrack_netlink.c
===================================================================
@@ -808,7 +808,7 @@ ctnetlink_get_conntrack(struct sock *ctn
 free:
 	kfree_skb(skb2);
 out:
-	return -1;
+	return err;
 }
 
 static inline int
Applied
#1 lore raw
Quoted 2 lines · Pablo Neira

Propagate the error to userspace instead of returning -EPERM if the get conntrack operation fails.

thanks, applied.

Signature · 5 lines
- Harald Welte <[email protected]>                 http://netfilter.org/
============================================================================
  "Fragmentation is like classful addressing -- an interesting early
   architectural error that shows how much experimentation was going
   on while IP was being designed."                    -- Paul Vixie