Skip to contentSkip to conversation

saa711x driver doesn't need segment.h

PATCH Dave Jones 3 participants 3 messages Nov 10, 2005 – Nov 16, 2005 Media (V4L/DVB)

lore
Share & tools
lore

Dave Jones

author
#0 lore raw

This breaks compilation on non-x86 architectures,
and isn't even used.

drivers/media/video/saa711x.c renamed from drivers/media/video/saa711x.c~ +0 -1
@@ -36,7 +36,6 @@
 #include <asm/pgtable.h>
 #include <asm/page.h>
 #include <linux/sched.h>
-#include <asm/segment.h>
 #include <linux/types.h>
 #include <asm/uaccess.h>
 #include <linux/videodev.h>
Acked-by Michael Krufky
#1 lore raw
Quoted 16 lines · Dave Jones

This breaks compilation on non-x86 architectures,
and isn't even used.

drivers/media/video/saa711x.c renamed from drivers/media/video/saa711x.c~ +0 -2
@@ -36,7 +36,6 @@
 #include <asm/pgtable.h>
 #include <asm/page.h>
 #include <linux/sched.h>
-#include <asm/segment.h>
 #include <linux/types.h>
 #include <asm/uaccess.h>
 #include <linux/videodev.h>
-
Quoted 6 lines

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Andrew-

Due to the above fix, please revert:

saa711x-is-busted-on-ppc64.patch

Thank you.

Signature · 1 line
Michael Krufky
#2 lore raw
Quoted 28 lines · Mike Krufky
Quoted 18 lines · Dave Jones

This breaks compilation on non-x86 architectures,
and isn't even used.

--- linux-2.6.14/drivers/media/video/saa711x.c~ 2005-11-10
15:27:05.000000000 -0500
+++ linux-2.6.14/drivers/media/video/saa711x.c 2005-11-10
15:27:33.000000000 -0500

drivers/media/video/saa711x.c renamed from drivers/media/video/saa711x.c~ +0 -2
@@ -36,7 +36,6 @@
 #include <asm/pgtable.h>
 #include <asm/page.h>
 #include <linux/sched.h>
-#include <asm/segment.h>
 #include <linux/types.h>
 #include <asm/uaccess.h>
 #include <linux/videodev.h>
-
Quoted 6 lines

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Quoted 8 lines

Andrew-

Due to the above fix, please revert:

saa711x-is-busted-on-ppc64.patch

Thank you.

Just tested out saa711x module with the USBVision driver and it works perfectly. It's nice to have this module included with the v4l.