Skip to contentSkip to conversation

Update MediaTek disp_aal dt-binding

PATCH Applied Rex-BC Chen 4 participants 9 messages Apr 11, 2022 – Apr 22, 2022

Subsystems (5)
lore
Share & tools
lore
#0 lore raw

v2 cover Update MediaTek disp_aal dt-binding

V2:
1. Change to a proper subject.
2. Update dt-binding for MT8195.

The disp_aal dt-binding needs to be updated for MT8183, MT8192 and MT8195.
1. Update dt-binding and dts for MT8183.
2. Update dt-binding for MT8192 and MT8195.

This series is based on this series:
"add display support for MediaTek SoC MT8186":
Message id: [email protected]

Rex-BC Chen (3):
dt-bindings: display: mediatek: Update disp_aal binding for MT8183
arm64: dts: mt8183: Update disp_aal node compatible
dt-bindings: display: mediatek: Update disp_aal binding for MT8192 and MT8195

 .../bindings/display/mediatek/mediatek,aal.yaml        | 10 +++++-----
 arch/arm64/boot/dts/mediatek/mt8183.dtsi               |  3 +--
 2 files changed, 6 insertions(+), 7 deletions(-)
Signature · 1 line
2.18.0
#1 lore raw

PATCH v2 1/3 dt-bindings: display: mediatek: Update disp_aal binding for MT8183

The driver data of MT8183 and MT8173 are different.

For MT8173, the gamma module is inside disp_aal. When we need to adjust gamma value, we need to use "has_gamma" to control gamma function inside disp_aal to adjust the gamma value.

For successors like MT8183, disp_gamma is separated from disp_aal. We just need to control disp_gamma directly and don't need to control gamma function inside disp_aal.

With this modification, the driver doesn't require any functional changes. We only update the dt-binding and DTS node to make it clear.

---
 .../devicetree/bindings/display/mediatek/mediatek,aal.yaml  | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
Documentation/devicetree/bindings/display/mediatek/mediatek,aal.yaml +3 -3
index cb4a2f39ff88..f118075e4a89 100644
@@ -21,12 +21,12 @@ description: |
 properties:
   compatible:
     oneOf:
-      - items:
-          - const: mediatek,mt8173-disp-aal
+      - enum:
+          - mediatek,mt8173-disp-aal
+          - mediatek,mt8183-disp-aal
       - items:
           - enum:
               - mediatek,mt2712-disp-aal
-              - mediatek,mt8183-disp-aal
               - mediatek,mt8192-disp-aal
               - mediatek,mt8195-disp-aal
           - const: mediatek,mt8173-disp-aal
Signature · 1 line
2.18.0
maintainer Acked-by on v2 1/3
#2 lore raw

Re: [PATCH V2 1/3] dt-bindings: display: mediatek: Update disp_aal binding for MT8183

Quoted 10 lines · Rex-BC Chen

The driver data of MT8183 and MT8173 are different.

For MT8173, the gamma module is inside disp_aal. When we need to adjust gamma value, we need to use "has_gamma" to control gamma function inside disp_aal to adjust the gamma value.

For successors like MT8183, disp_gamma is separated from disp_aal. We just need to control disp_gamma directly and don't need to control gamma function inside disp_aal.

Quoted 9 lines

With this modification, the driver doesn't require any functional changes. We only update the dt-binding and DTS node to make it clear.

---
 .../devicetree/bindings/display/mediatek/mediatek,aal.yaml  | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
maintainer Applied
#3 lore raw

Re: [PATCH V2 1/3] dt-bindings: display: mediatek: Update disp_aal binding for MT8183

Rob Herring <[email protected]> 於 2022年4月14日 週四 上午7:02寫道:

Quoted 15 lines · Rex-BC Chen
Quoted 13 lines

The driver data of MT8183 and MT8173 are different.

For MT8173, the gamma module is inside disp_aal. When we need to adjust gamma value, we need to use "has_gamma" to control gamma function inside disp_aal to adjust the gamma value.

For successors like MT8183, disp_gamma is separated from disp_aal. We just need to control disp_gamma directly and don't need to control gamma function inside disp_aal.

With this modification, the driver doesn't require any functional changes. We only update the dt-binding and DTS node to make it clear.

Quoted 8 lines
Quoted 6 lines
---
 .../devicetree/bindings/display/mediatek/mediatek,aal.yaml  | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Applied to mediatek-drm-next [1], thanks.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?h=mediatek-drm-next

Regards,
Chun-Kuang.

#4 lore raw

PATCH v2 2/3 arm64: dts: mt8183: Update disp_aal node compatible

In reply to Rex-BC Chen

The driver data of MT8183 and MT8173 are different.
The value of has_gamma for MT8173 is true while the value of MT8183 is false. Therefore, the compatible of disp_aal for MT8183 is not suitable for the compatible for MT8173.

---
 arch/arm64/boot/dts/mediatek/mt8183.dtsi | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
arch/arm64/boot/dts/mediatek/mt8183.dtsi +1 -2
index 4b08691ed39e..a3616005d65c 100644
@@ -1466,8 +1466,7 @@
 		};
 
 		aal0: aal@14010000 {
-			compatible = "mediatek,mt8183-disp-aal",
-				     "mediatek,mt8173-disp-aal";
+			compatible = "mediatek,mt8183-disp-aal";
 			reg = <0 0x14010000 0 0x1000>;
 			interrupts = <GIC_SPI 233 IRQ_TYPE_LEVEL_LOW>;
 			power-domains = <&spm MT8183_POWER_DOMAIN_DISP>;
Signature · 1 line
2.18.0
maintainer
#5 lore raw

Re: [PATCH V2 2/3] arm64: dts: mt8183: Update disp_aal node compatible

Quoted 7 lines · Rex-BC Chen

The driver data of MT8183 and MT8173 are different.
The value of has_gamma for MT8173 is true while the value of MT8183 is false. Therefore, the compatible of disp_aal for MT8183 is not suitable for the compatible for MT8173.

Applied thanks!

Quoted 18 lines
---
  arch/arm64/boot/dts/mediatek/mt8183.dtsi | 3 +--
  1 file changed, 1 insertion(+), 2 deletions(-)
arch/arm64/boot/dts/mediatek/mt8183.dtsi +1 -2
index 4b08691ed39e..a3616005d65c 100644
@@ -1466,8 +1466,7 @@
  		};
 
  		aal0: aal@14010000 {
-			compatible = "mediatek,mt8183-disp-aal",
-				     "mediatek,mt8173-disp-aal";
+			compatible = "mediatek,mt8183-disp-aal";
  			reg = <0 0x14010000 0 0x1000>;
  			interrupts = <GIC_SPI 233 IRQ_TYPE_LEVEL_LOW>;
  			power-domains = <&spm MT8183_POWER_DOMAIN_DISP>;
#6 lore raw

PATCH v2 3/3 dt-bindings: display: mediatek: Update disp_aal binding for MT8192 and MT8195

In reply to Rex-BC Chen

Disp_aal of MT8192 and MT8195 are fully compatible with disp_aal of MT8183. Therefore, we move the them to item "mediatek,mt8183-disp-aal".

---
 .../devicetree/bindings/display/mediatek/mediatek,aal.yaml    | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Documentation/devicetree/bindings/display/mediatek/mediatek,aal.yaml +2 -2
index f118075e4a89..d4d585485e7b 100644
@@ -27,12 +27,12 @@ properties:
       - items:
           - enum:
               - mediatek,mt2712-disp-aal
-              - mediatek,mt8192-disp-aal
-              - mediatek,mt8195-disp-aal
           - const: mediatek,mt8173-disp-aal
       - items:
           - enum:
               - mediatek,mt8186-disp-aal
+              - mediatek,mt8192-disp-aal
+              - mediatek,mt8195-disp-aal
           - const: mediatek,mt8183-disp-aal
 
   reg:
Signature · 1 line
2.18.0
maintainer Acked-by on v2 3/3
#7 lore raw

Re: [PATCH V2 3/3] dt-bindings: display: mediatek: Update disp_aal binding for MT8192 and MT8195

Quoted 8 lines · Rex-BC Chen

Disp_aal of MT8192 and MT8195 are fully compatible with disp_aal of MT8183. Therefore, we move the them to item "mediatek,mt8183-disp-aal".

---
 .../devicetree/bindings/display/mediatek/mediatek,aal.yaml    | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
maintainer Applied
#8 lore raw

Re: [PATCH V2 3/3] dt-bindings: display: mediatek: Update disp_aal binding for MT8192 and MT8195

Rob Herring <[email protected]> 於 2022年4月14日 週四 上午7:02寫道:

Quoted 12 lines · Rex-BC Chen
Quoted 8 lines

Disp_aal of MT8192 and MT8195 are fully compatible with disp_aal of MT8183. Therefore, we move the them to item "mediatek,mt8183-disp-aal".

---
 .../devicetree/bindings/display/mediatek/mediatek,aal.yaml    | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Applied to mediatek-drm-next [1], thanks.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?h=mediatek-drm-next

Regards,
Chun-Kuang.