Skip to contentSkip to conversation

small fix for __ipv6_addr_type(...)

PATCH In review Yan Zheng 3 participants 3 messages Nov 13, 2005 – Nov 16, 2005

Subsystems (3)
Networking Network drivers IPv4/IPv6
lore
Share & tools
lore

Yan Zheng

author
#0 lore raw

PATCH 1/1 small fix for __ipv6_addr_type(...)

Hi.

I think the scope for loopback address should be node local.

Regards

Signed-off-by Yan Zheng <[email protected]>

========================================================================

net/ipv6/addrconf.c +0 -0
@@ -249,7 +249,7 @@ int __ipv6_addr_type(const struct in6_ad
 

			if (addr->s6_addr32[3] == htonl(0x00000001))
				return (IPV6_ADDR_LOOPBACK | IPV6_ADDR_UNICAST |

- IPV6_ADDR_SCOPE_TYPE(IPV6_ADDR_SCOPE_LINKLOCAL)); /* addr-select 3.4 */
+ IPV6_ADDR_SCOPE_TYPE(IPV6_ADDR_SCOPE_NODELOCAL)); /* addr-select 3.4 */

			return (IPV6_ADDR_COMPATv4 | IPV6_ADDR_UNICAST |
				IPV6_ADDR_SCOPE_TYPE(IPV6_ADDR_SCOPE_GLOBAL));	/* addr-select 3.3 */
#1 lore raw

No, according to RFC 4007, loopback is considered a link-local address.

-vlad

Quoted 29 lines · Yan Zheng

Hi.

I think the scope for loopback address should be node local.

Regards

Signed-off-by Yan Zheng <[email protected]>

========================================================================
--- linux-2.6.15-rc1/net/ipv6/addrconf.c 2005-11-13
12:23:06.000000000 +0800
+++ linux/net/ipv6/addrconf.c 2005-11-13 15:50:03.000000000 +0800

(quoted diff) +0 -1
@@ -249,7 +249,7 @@ int __ipv6_addr_type(const struct in6_ad
 
            if (addr->s6_addr32[3] == htonl(0x00000001))
                return (IPV6_ADDR_LOOPBACK | IPV6_ADDR_UNICAST |
-

IPV6_ADDR_SCOPE_TYPE(IPV6_ADDR_SCOPE_LINKLOCAL)); /* addr-select 3.4 */
+
IPV6_ADDR_SCOPE_TYPE(IPV6_ADDR_SCOPE_NODELOCAL)); /* addr-select 3.4 */

return (IPV6_ADDR_COMPATv4 | IPV6_ADDR_UNICAST |
IPV6_ADDR_SCOPE_TYPE(IPV6_ADDR_SCOPE_GLOBAL)); /*
addr-select 3.3 */
-
To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html