Skip to contentSkip to conversation

update-ethaddr-handling-on-cmc-pu2-board.patch

PATCH New Martin Krause 3 participants 3 messages Nov 16, 2005

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 update-ethaddr-handling-on-cmc-pu2-board.patch

Update ethaddr handling on CMC-PU2 board
Patch by Martin Krause, 16 Nov 2005

If the environment variable 'ethaddr' is not set in flash it is read from EEPROM (if valid), set in RAM and now also saved to flash. The same applies for the variable 'serial#'.
This is done to optimise series production. Now, no 'saveenv' command has to be applied over the serial line. And thus no serial connection is necessery at all. Setting ethaddr only in RAM is not sufficient, because 'ethaddr' and 'serial#' must be readable from linux with the fw_printenv tool.

CHANGELOG:

* Update ethaddr handling on CMC-PU2 board
Patch by Martin Krause, 16 Nov 2005

Regards,
Martin
---
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 02-update-ethaddr-handling-on-cmc-pu2-board.patch
Type: application/octet-stream
Size: 2621 bytes
Desc: 02-update-ethaddr-handling-on-cmc-pu2-board.patch
Url : http://lists.denx.de/pipermail/u-boot/attachments/20051116/9cb0c490/attachment.obj

#1 lore raw

PATCH 1/1 update-ethaddr-handling-on-cmc-pu2-board.patch

Quoted 14 lines · Martin Krause

Update ethaddr handling on CMC-PU2 board
Patch by Martin Krause, 16 Nov 2005

If the environment variable 'ethaddr' is not set in flash it is read from EEPROM (if valid), set in RAM and now also saved to flash. The same applies for the variable 'serial#'.
This is done to optimise series production. Now, no 'saveenv' command has to be applied over the serial line. And thus no serial connection is necessery at all. Setting ethaddr only in RAM is not sufficient, because 'ethaddr' and 'serial#' must be readable from linux with the fw_printenv tool.

Quoted 8 lines

CHANGELOG:

* Update ethaddr handling on CMC-PU2 board
Patch by Martin Krause, 16 Nov 2005

Regards,
Martin
---

I disagree. If you need this, pass the u-boot environment to the linux kernel, or add a serial# member in bd_t.

Regards

Pantelis

#2 lore raw

PATCH 1/1 update-ethaddr-handling-on-cmc-pu2-board.patch

In reply to Martin Krause
Quoted 4 lines · In message <[email protected]> you…

If the environment variable 'ethaddr' is not set in flash it is read from EEPROM (if valid), set in RAM and now also saved to flash. The same applies for the variable 'serial#'.

I reject this patch. SO far we never to automatically modify environ- ment in flash. All the other TQ boards which do similar things just read the data and set it in the environment, but don't automatically safe it to flash.

Best regards,

Wolfgang Denk

Signature · 4 lines
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
No question is too silly to ask. Of course, some  questions  are  too
silly to to answer...  - L. Wall & R. L. Schwartz, _Programming Perl_