Skip to contentSkip to conversation

Funny looking code in __rpc_purge_upcall

PATCH Vince Busam 3 participants 3 messages Nov 17, 2005

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

In __rpc_purge_upcall (net/sunrpc/rpc_pipe.c), the newer code to clean up the in_upcall list looks bad. Shouldn't the first argument to list_entry() be rpci->in_upcall.next?

sunrpc/rpc_pipe.c 2005-11-16 16:52:23.000000000 -0800 renamed from sunrpc/rpc_pipe.c.orig 2005-11-16 16:48:00.000000000 -0800 +1 -1
@@ -51,7 +51,7 @@ __rpc_purge_upcall(struct inode *inode,
                rpci->ops->destroy_msg(msg);
        }
        while (!list_empty(&rpci->in_upcall)) {
-               msg = list_entry(rpci->pipe.next, struct rpc_pipe_msg, list);
+               msg = list_entry(rpci->in_upcall.next, struct rpc_pipe_msg, list);
                list_del_init(&msg->list);
                msg->errno = err;
                rpci->ops->destroy_msg(msg);

Vince

-------------------------------------------------------
This SF.Net email is sponsored by the JBoss Inc. Get Certified Today Register for a JBoss Training Course. Free Certification Exam for All Training Attendees Through End of 2005. For more info visit:
http://ads.osdn.com/?ad_id=7628&alloc_id=16845&op=click
_______________________________________________
NFS maillist - [email protected]
https://lists.sourceforge.net/lists/listinfo/nfs

#1 lore raw
Quoted 2 lines · Vince Busam

In __rpc_purge_upcall (net/sunrpc/rpc_pipe.c), the newer code to clean up the in_upcall list looks bad. Shouldn't the first argument to list_entry() be rpci->in_upcall.next?

Doh! Well spotted!

That might explain the rpc-pipe related cleanup problem that Steve Dickson has reported on the list earlier...

Cheers,
Trond

Quoted 15 lines
sunrpc/rpc_pipe.c 2005-11-16 16:52:23.000000000 -0800 renamed from sunrpc/rpc_pipe.c.orig 2005-11-16 16:48:00.000000000 -0800 +1 -1
@@ -51,7 +51,7 @@ __rpc_purge_upcall(struct inode *inode,
                 rpci->ops->destroy_msg(msg);
         }
         while (!list_empty(&rpci->in_upcall)) {
-               msg = list_entry(rpci->pipe.next, struct rpc_pipe_msg, list);
+               msg = list_entry(rpci->in_upcall.next, struct rpc_pipe_msg, list);
                 list_del_init(&msg->list);
                 msg->errno = err;
                 rpci->ops->destroy_msg(msg);

Vince

Quoted 8 lines

-------------------------------------------------------
This SF.Net email is sponsored by the JBoss Inc. Get Certified Today Register for a JBoss Training Course. Free Certification Exam for All Training Attendees Through End of 2005. For more info visit:
http://ads.osdn.com/?ad_id=7628&alloc_id=16845&op=click
_______________________________________________
NFS maillist - [email protected]
https://lists.sourceforge.net/lists/listinfo/nfs

-------------------------------------------------------
This SF.Net email is sponsored by the JBoss Inc. Get Certified Today Register for a JBoss Training Course. Free Certification Exam for All Training Attendees Through End of 2005. For more info visit:
http://ads.osdn.com/?ad_id=7628&alloc_id=16845&op=click
_______________________________________________
NFS maillist - [email protected]
https://lists.sourceforge.net/lists/listinfo/nfs

#2 lore raw
Quoted 2 lines · Trond Myklebust

That might explain the rpc-pipe related cleanup problem that Steve Dickson has reported on the list earlier...

No go... :-( I just tried that patch and unfortunately it does not stop the oops that you are referring to...

steved.

-------------------------------------------------------
This SF.Net email is sponsored by the JBoss Inc. Get Certified Today Register for a JBoss Training Course. Free Certification Exam for All Training Attendees Through End of 2005. For more info visit:
http://ads.osdn.com/?ad_id=7628&alloc_id=16845&op=click
_______________________________________________
NFS maillist - [email protected]
https://lists.sourceforge.net/lists/listinfo/nfs