sound/oss/maestro3.c printk args concatenation
Subsystems (2)
PATCH 1/1 sound/oss/maestro3.c printk args concatenation
Removed string concatenation in printk args
sound/oss/maestro3.c +0 -0
@@ -2935,7 +2935,7 @@ static struct pci_driver m3_pci_driver =
static int __init m3_init_module(void)
{
- printk(KERN_INFO PFX "version " DRIVER_VERSION " built at " __TIME__ " " __DATE__ "\n");
+ printk(KERN_INFO "%sversion %s built at %s %s\n",PFX,DRIVER_VERSION,__TIME__, __DATE__);
if (register_reboot_notifier(&m3_reboot_nb)) {
printk(KERN_WARNING PFX "reboot notifier registration failed\n");Signature · 2 lines
Witold Rugowski rugowski _at_ nhw.pl http://nhw.pl/blg/
_______________________________________________
Kernel-janitors mailing list
[email protected]
https://lists.osdl.org/mailman/listinfo/kernel-janitors
Quoted 8 lines · Witold Rugowski
Removed string concatenation in printk args
Signed-off-by Witold Rugowski <[email protected]>diff -urpN
linux-2.6.14.2/sound/oss/maestro3.clinux-2.6.14.2-wr/sound/oss/maestro3.c
sound/oss/maestro3.c Fri Nov 18 23:56:37 2005 static struct pci_driver m3_pci_driver > · line 2939
Quoted 6 lines
sound/oss/maestro3.c Fri Nov 18 23:56:37 2005 renamed from sound/oss/maestro3.c Fri Nov 11 06:33:12 2005 +1
-1@@ -2935,7 +2935,7 @@ static struct pci_driver m3_pci_driver > static int __init m3_init_module(void) { - printk(KERN_INFO PFX "version " DRIVER_VERSION " built at " __TIME__ " "__DATE__ "\n"); + printk(KERN_INFO "%sversion %s built at %s %s\n",PFX,DRIVER_VERSION,__TIME__, __DATE__);
Missing spaces?
printk(KERN_INFO "%s version %s built at %s %s\n", PFX, DRIVER_VERSION, __TIME__, __DATE__);
Thanks,
Nish
_______________________________________________
Kernel-janitors mailing list
[email protected]
https://lists.osdl.org/mailman/listinfo/kernel-janitors
Quoted 1 line · Nish Aravamudan
Missing spaces?
Yes. But that was my first time ;-)) so - improved patch version follows:
sound/oss/maestro3.c +2 -1
@@ -2935,7 +2935,8 @@ static struct pci_driver m3_pci_driverstatic int __init m3_init_module (void ) { - printk(KERN_INFO PFX "version " DRIVER_VERSION " built at " __TIME__ " " __DATE__ "\n"); +printk (KERN_INFO "%sversion %s built at %s %s\n" ,PFX ,DRIVER_VERSION , + __TIME__, __DATE__);if (register_reboot_notifier (&m3_reboot_nb)) { printk(KERN_WARNING PFX "reboot notifier registration failed\n");
Signature · 6 lines
Witold Rugowski rugowski _at_ nhw.pl http://nhw.pl/blg/ _______________________________________________ Kernel-janitors mailing list [email protected] https://lists.osdl.org/mailman/listinfo/kernel-janitors
Quoted 4 lines · Witold Rugowski
Quoted 1 line · Nish Aravamudan
Missing spaces?
Yes. But that was my first time ;-)) so - improved patch version follows:
No problem. You need to provide a description and Signed-off-by line with every patch, though, to make the maintainer's job easier.
Otherwise looks ok, except you're patching an obsolete subsystem (OSS). I wouldn't bother.
Thanks,
Nish
_______________________________________________
Kernel-janitors mailing list
[email protected]
https://lists.osdl.org/mailman/listinfo/kernel-janitors
Quoted 1 line · Witold Rugowski
Removed string concatenation in printk args
Why would you turn a compile-time string concatenation into a run-time string concatenation? I am not sure what the benefits from doing that should be.
BR Håkon Løvdal
_______________________________________________
Kernel-janitors mailing list
[email protected]
https://lists.osdl.org/mailman/listinfo/kernel-janitors
Quoted 5 lines · Håkon Løvdal
Quoted 1 line · Witold Rugowski
Removed string concatenation in printk args
Why would you turn a compile-time string concatenation into a run-time string concatenation? I am not sure what the benefits from doing that should be.
Good point. Depends on when gcc evaluates __TIME__ and __DATE__? In any case, the OSS driver in question has an ALSA version, which means that it's fully deprecated and probably will be gotten rid of by Adrian Bunk soon enough. Unless it has functionality that the ALSA driver doesn't. In any case, I would just forget about this patch.
Thanks,
Nish
_______________________________________________
Kernel-janitors mailing list
[email protected]
https://lists.osdl.org/mailman/listinfo/kernel-janitors
Quoted 2 lines · Nish Aravamudan
Adrian Bunk soon enough. Unless it has functionality that the ALSA driver doesn't. In any case, I would just forget about this patch.
It was just a first patch of mine;-)) so let's forget about it. I will check wheter on KJ TODO I find something suitable for me. And will see what will be with second one ;-))
Signature · 6 lines
Witold Rugowski rugowski _at_ nhw.pl http://nhw.pl/blg/ _______________________________________________ Kernel-janitors mailing list [email protected] https://lists.osdl.org/mailman/listinfo/kernel-janitors
Quoted 7 lines · Witold Rugowski
Quoted 2 lines · Nish Aravamudan
Adrian Bunk soon enough. Unless it has functionality that the ALSA driver doesn't. In any case, I would just forget about this patch.
It was just a first patch of mine;-)) so let's forget about it. I will check wheter on KJ TODO I find something suitable for me. And will see what will be with second one ;-))
It was a good effort, Witold, and generally the right thing to look for. Look forward to seeing more patches from you in the future.
Thanks,
Nish
_______________________________________________
Kernel-janitors mailing list
[email protected]
https://lists.osdl.org/mailman/listinfo/kernel-janitors