Skip to contentSkip to conversation

PATA support for Intel ICH7 (intel 945G chipset) - 2.6.14.2

PATCH In review Jan Panoch 4 participants 4 messages Nov 23, 2005 – Nov 24, 2005 libata

lore
Share & tools
lore

Jan Panoch

author
#0 lore raw

PATCH 1/1 PATA support for Intel ICH7 (intel 945G chipset) - 2.6.14.2

Hi,

This patch adds additional Intel ICH7 DID's for Intel chipset 945G to the piix driver.
I need to add PATA support for new intel 945G chipset on Asus motherboard P5LD2-VM.
If acceptable, please apply.

Thanks,

Jan

piix.c 2005-11-23 11:13:02.000000000 +0100 renamed from piix.c.orig 2005-11-23 11:46:12.000000000 +0100 +3 -0
@@ -134,6 +134,7 @@
                case PCI_DEVICE_ID_INTEL_ESB_2:
                case PCI_DEVICE_ID_INTEL_ICH6_19:
                case PCI_DEVICE_ID_INTEL_ICH7_21:
+               case PCI_DEVICE_ID_INTEL_ICH7_2:
                case PCI_DEVICE_ID_INTEL_ESB2_18:
                        mode = 3;
                        break;

@@ -448,6 +449,7 @@
                case PCI_DEVICE_ID_INTEL_ESB_2:
                case PCI_DEVICE_ID_INTEL_ICH6_19:
                case PCI_DEVICE_ID_INTEL_ICH7_21:
+               case PCI_DEVICE_ID_INTEL_ICH7_2:
                case PCI_DEVICE_ID_INTEL_ESB2_18:
                {
                        unsigned int extra = 0;

@@ -575,6 +577,7 @@
        /* 21 */ DECLARE_PIIX_DEV("ICH7"),
        /* 22 */ DECLARE_PIIX_DEV("ICH4"),
        /* 23 */ DECLARE_PIIX_DEV("ESB2"),
+       /* 24 */ DECLARE_PIIX_DEV("ICH7"),
 };
 
 /**

@@ -651,6 +654,7 @@
        { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_ICH7_21, PCI_ANY_ID,

PCI_ANY_ID, 0, 0, 21},

        { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_82801DB_1,
PCI_ANY_ID, PCI_ANY_ID, 0, 0, 22},
        { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_ESB2_18, PCI_ANY_ID,
PCI_ANY_ID, 0, 0, 23},
+       { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_ICH7_2, PCI_ANY_ID,
PCI_ANY_ID, 0, 0, 24},
        { 0, },

};
MODULE_DEVICE_TABLE(pci, piix_pci_tbl);

Signature · 5 lines
Jan Panoch

======================
mail:   [email protected]
Skype:  jan.panoch
#1 lore raw
Quoted 7 lines · Jan Panoch

Hi,

This patch adds additional Intel ICH7 DID's for Intel chipset 945G to the piix driver.
I need to add PATA support for new intel 945G chipset on Asus motherboard P5LD2-VM.
If acceptable, please apply.

PCI_DEVICE_ID_INTEL_ICH7_2 has been removed in 2.6.15 as it was unused.
Your patch is whitespace damaged (mailer ate the tabs?). You also need to send it to the linux-ide list and the IDE maintainer (see Documentation/SubmittingPatches). I don't think it will be accepted because this hardware is already supported by the ata_piix libata driver.

Quoted 40 lines
piix.c 2005-11-23 11:13:02.000000000 +0100 renamed from piix.c.orig 2005-11-23 11:46:12.000000000 +0100 +4 -0
@@ -134,6 +134,7 @@
                case PCI_DEVICE_ID_INTEL_ESB_2:
                case PCI_DEVICE_ID_INTEL_ICH6_19:
                case PCI_DEVICE_ID_INTEL_ICH7_21:
+               case PCI_DEVICE_ID_INTEL_ICH7_2:
                case PCI_DEVICE_ID_INTEL_ESB2_18:
                        mode = 3;
                        break;

@@ -448,6 +449,7 @@
                case PCI_DEVICE_ID_INTEL_ESB_2:
                case PCI_DEVICE_ID_INTEL_ICH6_19:
                case PCI_DEVICE_ID_INTEL_ICH7_21:
+               case PCI_DEVICE_ID_INTEL_ICH7_2:
                case PCI_DEVICE_ID_INTEL_ESB2_18:
                {
                        unsigned int extra = 0;

@@ -575,6 +577,7 @@
        /* 21 */ DECLARE_PIIX_DEV("ICH7"),
        /* 22 */ DECLARE_PIIX_DEV("ICH4"),
        /* 23 */ DECLARE_PIIX_DEV("ESB2"),
+       /* 24 */ DECLARE_PIIX_DEV("ICH7"),
 };
 
 /**

@@ -651,6 +654,7 @@
        { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_ICH7_21, PCI_ANY_ID,
 PCI_ANY_ID, 0, 0, 21},
        { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_82801DB_1,
 PCI_ANY_ID, PCI_ANY_ID, 0, 0, 22},
        { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_ESB2_18, PCI_ANY_ID,
 PCI_ANY_ID, 0, 0, 23},
+       { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_ICH7_2, PCI_ANY_ID,

PCI_ANY_ID, 0, 0, 24},

        { 0, },

};
MODULE_DEVICE_TABLE(pci, piix_pci_tbl);

#2 lore raw
Quoted 2 lines · Daniel Drake

Documentation/SubmittingPatches). I don't think it will be accepted because this hardware is already supported by the ata_piix libata driver.

That is not a valid reason to reject -- libata is still considered very experimental for ATAPI devices, which are not enabled by default.

Jeff has said that he prefers (at present) for people with ATAPI drives to use the IDE layer rather than libata, where possible.

That will change soon, but it's still the case for now.

Cheers

#3 lore raw
Quoted 11 lines · Mark Lord
Quoted 2 lines · Daniel Drake

Documentation/SubmittingPatches). I don't think it will be accepted because this hardware is already supported by the ata_piix libata driver.

That is not a valid reason to reject -- libata is still considered very experimental for ATAPI devices, which are not enabled by default.

Jeff has said that he prefers (at present) for people with ATAPI drives to use the IDE layer rather than libata, where possible.

PATA ATAPI, not all ATAPI...

Jeff