ACPI EC driver on ia64

PATCH In review Kenji Kaneshige 2 participants 3 messages Dec 5, 2005 – Dec 6, 2005 1 message not in the archive ACPI

lore

Share & tools

lore

Kenji Kaneshige

author

2005-12-05 10:45 UTC #0 lore raw

PATCH 1/1 ACPI EC driver on ia64

Hi,

I need an ACPI EC driver on my IA64 machine. Currently CONFIG_ACPI_EC depends on X86, so I cannot build ACPI EC driver on ia64. I tested ACPI EC driver on ia64 with my special Kconfig, and it seemed to work well. Could you consider applying the following patch to enable ACPI EC driver on ia64?

Thanks,
Kenji Kaneshige

This patch enables ACPI EC driver on ia64.

Signed-off-by Kenji Kaneshige <[email protected]>

 drivers/acpi/Kconfig |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)

drivers/acpi/Kconfig +1 -1

Index: linux-2.6.15-rc5/drivers/acpi/Kconfig
===================================================================
@@ -269,7 +269,7 @@ config ACPI_DEBUG
 
 config ACPI_EC
 	bool
-	depends on X86
+	depends on IA64 || X86
 	default y
 	help
 	  This driver is required on some systems for the proper operation of

A message that is not in the archive (sent off-list or not yet received): [email protected]

Bjorn Helgaas

2005-12-05 16:11 UTC #2 lore raw

drivers/acpi/Kconfig config ACPI_DEBUG · line 272

Quoted 10 lines · Kenji Kaneshige

I need an ACPI EC driver on my IA64 machine. Currently CONFIG_ACPI_EC depends on X86, so I cannot build ACPI EC driver on ia64. I tested ACPI EC driver on ia64 with my special Kconfig, and it seemed to work well. Could you consider applying the following patch to enable ACPI EC driver on ia64?
config ACPI_EC
drivers/acpi/Kconfig +1 -1
 	bool
-	depends on X86
+	depends on IA64 || X86

Why not just remove the "depends on" altogether? I don't see anything in ec.c that's architecture-dependent.

-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files for problems? Stop! Download the new AJAX search engine that makes searching your log files as easy as surfing the web. DOWNLOAD SPLUNK!
http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click

Kenji Kaneshige

author

2005-12-06 04:49 UTC #3 lore raw

Quoted 9 lines

Review
Quoted 4 lines
config ACPI_EC
bool
(quoted diff) +1 -1
-	depends on X86
+	depends on IA64 || X86
Why not just remove the "depends on" altogether? I don't see anything in ec.c that's architecture-dependent.

Only the reason was I didn't have x86_64 machine for testing ACPI EC driver. But I think "depends on" should be removed, as you said.

I'm attaching the updated patch.

Thanks,
Kenji Kaneshige

This patch removes "depends on X86" from config ACPI_EC. With this patch, ACPI EC driver will be built also on x86_64 and ia64.

Signed-off-by Kenji Kaneshige <[email protected]>

 drivers/acpi/Kconfig |    1 -
 1 files changed, 1 deletion(-)

drivers/acpi/Kconfig +0 -1

Index: linux-2.6.15-rc5/drivers/acpi/Kconfig
===================================================================
@@ -269,7 +269,6 @@ config ACPI_DEBUG
 
 config ACPI_EC
 	bool
-	depends on X86
 	default y
 	help
 	  This driver is required on some systems for the proper operation of