Skip to contentSkip to conversation

rivafb: Trim rivafb_pan_display

PATCH In review Antonino A. Daplas 1 participant 1 message Dec 10, 2005 Framebuffer layer

lore
Share & tools
lore
#0 lore raw

PATCH 3/18 rivafb: Trim rivafb_pan_display

Remove error checking and updating from rivafb_pan_display. This is guaranteed to be done by the core layer.

---

 drivers/video/riva/fbdev.c |   24 ------------------------
 1 files changed, 0 insertions(+), 24 deletions(-)
drivers/video/riva/fbdev.c +0 -24
index dd7b2cc..6c19ab6 100644
@@ -1209,32 +1209,8 @@ static int rivafb_pan_display(struct fb_
 	unsigned int base;
 
 	NVTRACE_ENTER();
-	if (var->xoffset > (var->xres_virtual - var->xres))
-		return -EINVAL;
-	if (var->yoffset > (var->yres_virtual - var->yres))
-		return -EINVAL;
-
-	if (var->vmode & FB_VMODE_YWRAP) {
-		if (var->yoffset < 0
-		    || var->yoffset >= info->var.yres_virtual
-		    || var->xoffset) return -EINVAL;
-	} else {
-		if (var->xoffset + info->var.xres > info->var.xres_virtual ||
-		    var->yoffset + info->var.yres > info->var.yres_virtual)
-			return -EINVAL;
-	}
-
 	base = var->yoffset * info->fix.line_length + var->xoffset;
-
 	par->riva.SetStartAddress(&par->riva, base);
-
-	info->var.xoffset = var->xoffset;
-	info->var.yoffset = var->yoffset;
-
-	if (var->vmode & FB_VMODE_YWRAP)
-		info->var.vmode |= FB_VMODE_YWRAP;
-	else
-		info->var.vmode &= ~FB_VMODE_YWRAP;
 	NVTRACE_LEAVE();
 	return 0;
 }

-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files for problems? Stop! Download the new AJAX search engine that makes searching your log files as easy as surfing the web. DOWNLOAD SPLUNK!
http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click