Skip to contentSkip to conversation

nfsim: Increase maximum argv size for tcpsession DATA

PATCH Applied Marcus Sundberg 2 participants 2 messages Dec 13, 2005 – Jan 6, 2006 netfilter

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 nfsim: Increase maximum argv size for tcpsession DATA

Hi,

this patch increases the argv buffer in the tcp_send() function. I ran in to this limit when constructing RTSP packets, and I see no reason not to make it "large enough for everyone" while at it.

tools/tcpsession.c +1 -1
@@ -124,7 +124,7 @@
 		     int datanum, char *data[])
 {
 	char *ctx = talloc(NULL, char);
-	char *argv[20];
+	char *argv[1024];
 	int argc;
 
 	argc = 0;
Signature · 3 lines
---------------------------------------+--------------------------
  Marcus Sundberg <[email protected]>  | Firewalls with SIP & NAT
 Software Developer, Ingate Systems AB |  http://www.ingate.com/
Applied
#1 lore raw
Quoted 5 lines · Marcus Sundberg

Hi,

this patch increases the argv buffer in the tcp_send() function. I ran in to this limit when constructing RTSP packets, and I see no reason not to make it "large enough for everyone" while at it.

thanks, applied.

Signature · 5 lines
- Harald Welte <[email protected]>                 http://netfilter.org/
============================================================================
  "Fragmentation is like classful addressing -- an interesting early
   architectural error that shows how much experimentation was going
   on while IP was being designed."                    -- Paul Vixie