Enable PINEBOOK Pro's display
Subsystems (4)
Hi,
We have a PINEBOOK Pro [1] equipped with Rockchip RK3399. I tried linux-next kernel at tag 5.9.0-rc5-next-20200915 with the build config [2]. However, the drm seems failed and also leads Xorg failed.
Here is the log [3]:
kernel: rockchip-dp ff970000.edp: no DP phy configured
kernel: cdn-dp fec00000.dp: [drm:cdn_dp_probe [rockchipdrm]] *ERROR* missing extcon or phy
kernel: cdn-dp: probe of fec00000.dp failed with error -22
...
gdm-Xorg-:0[660]: (EE) open /dev/fb0: No such file or directory gdm-Xorg-:0[660]: (EE) No devices detected. gdm-Xorg-:0[660]: (EE)
gdm-Xorg-:0[660]: Fatal server error:
gdm-Xorg-:0[660]: (EE) no screens found(EE)
Do I miss something? Any guidance will be appreciated.
[1] https://www.pine64.org/pinebook-pro/
[2] https://gist.github.com/starnight/66d27f7888d599247371adb1575d1092#file-config
[3] https://gist.github.com/starnight/66d27f7888d599247371adb1575d1092#file-journal-log
Jian-Hong Pan
_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip
PATCH 1/1 drm/rockchip: skip probed failed device
The cdn-dp sub driver probes the device failed on PINEBOOK Pro.
kernel: cdn-dp fec00000.dp: [drm:cdn_dp_probe [rockchipdrm]] *ERROR* missing extcon or phy
kernel: cdn-dp: probe of fec00000.dp failed with error -22
Then, the device halts all of the DRM related device jobs. For example, the operations: vop_component_ops, vop_component_ops and rockchip_dp_component_ops cannot be bound to corresponding devices. So, Xorg cannot find the correct DRM device.
This patch skips the probing failed devices to fix this issue.
--- drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 6 ++++++ 1 file changed, 6 insertions(+)
drivers/gpu/drm/rockchip/rockchip_drm_drv.c +6 -0
@@ -331,6 +331,12 @@ static struct component_match *rockchip_drm_match_add(struct device *dev)if (!d)break ; +if (!d->driver) { +DRM_DEV_ERROR (d, +"%s did not probe successfully" , + drv->driver.name); +continue ; + }device_link_add (dev, d,DL_FLAG_STATELESS );component_match_add (dev, &match, compare_dev, d);
Signature · 1 line
2.28.0
Heiko Stübner
maintainerRe: [PATCH] drm/rockchip: skip probed failed device
Hi,
Am Mittwoch, 23. September 2020, 08:59:00 CEST schrieb Jian-Hong Pan:
Quoted 23 lines
The cdn-dp sub driver probes the device failed on PINEBOOK Pro.
kernel: cdn-dp fec00000.dp: [drm:cdn_dp_probe [rockchipdrm]] *ERROR* missing extcon or phy
kernel: cdn-dp: probe of fec00000.dp failed with error -22Then, the device halts all of the DRM related device jobs. For example, the operations:
vop_component_ops,vop_component_opsandrockchip_dp_component_opscannot be bound to corresponding devices. So, Xorg cannot find the correct DRM device.This patch skips the probing failed devices to fix this issue.
Signed-off-by Jian-Hong Pan <[email protected]>--- drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 6 ++++++ 1 file changed, 6 insertions(+)drivers/gpu/drm/rockchip/rockchip_drm_drv.c +0
-0
drivers/gpu/drm/rockchip/rockchip_drm_drv.c static struct component_match *rockchip_drm_match_add(struct device *dev) · line 339
Quoted 9 lines
drivers/gpu/drm/rockchip/rockchip_drm_drv.c +6
-0@@ -331,6 +331,12 @@ static struct component_match *rockchip_drm_match_add(struct device *dev)if (!d)break ; +if (!d->driver) { +DRM_DEV_ERROR (d, +"%s did not probe successfully" , + drv->driver.name); +continue ; + }
How does this relate to drivers doing EPROBE_DEFER?
Very often you have sub-drivers defering probe as they still need another resource, so excluding them in that case would not work?
Heiko
Quoted 4 lines
drivers/gpu/drm/rockchip/rockchip_drm_drv.c +0
-0device_link_add (dev, d,DL_FLAG_STATELESS );component_match_add (dev, &match, compare_dev, d);
Re: [PATCH] drm/rockchip: skip probed failed device
In reply to Jian-Hong PanQuoted 4 lines · Jian-Hong Pan
The cdn-dp sub driver probes the device failed on PINEBOOK Pro.
kernel: cdn-dp fec00000.dp: [drm:cdn_dp_probe [rockchipdrm]] *ERROR* missing extcon or phy
kernel: cdn-dp: probe of fec00000.dp failed with error -22
Wouldn't it make more sense to simply not enable the DisplayPort node in the upstream DT, until the type-C phy work has been done to make it usable at all? AIUI the "official" Manjaro kernel is carrying a bunch of hacks to make type-C work via extcon, but they know that isn't an upstreamable solution.
Robin.
Quoted 21 lines
Then, the device halts all of the DRM related device jobs. For example, the operations:
vop_component_ops,vop_component_opsandrockchip_dp_component_opscannot be bound to corresponding devices. So, Xorg cannot find the correct DRM device.This patch skips the probing failed devices to fix this issue.
Signed-off-by Jian-Hong Pan <[email protected]>--- drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 6 ++++++ 1 file changed, 6 insertions(+)drivers/gpu/drm/rockchip/rockchip_drm_drv.c +0
-0@@ -331,6 +331,12 @@ static struct component_match *rockchip_drm_match_add(struct device *dev)if (!d)
drivers/gpu/drm/rockchip/rockchip_drm_drv.c static struct component_match *rockchip_drm_match_add(struct device *dev) · line 342
Quoted 10 lines
drivers/gpu/drm/rockchip/rockchip_drm_drv.c +6
-0break ; +if (!d->driver) { +DRM_DEV_ERROR (d, +"%s did not probe successfully" , + drv->driver.name); +continue ; + }device_link_add (dev, d,DL_FLAG_STATELESS );component_match_add (dev, &match, compare_dev, d);
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Heiko Stübner
maintainerRe: [PATCH] drm/rockchip: skip probed failed device
Am Mittwoch, 23. September 2020, 13:05:26 CEST schrieb Robin Murphy:
Quoted 9 lines · Jian-Hong Pan
Quoted 4 lines
The cdn-dp sub driver probes the device failed on PINEBOOK Pro.
kernel: cdn-dp fec00000.dp: [drm:cdn_dp_probe [rockchipdrm]] *ERROR* missing extcon or phy
kernel: cdn-dp: probe of fec00000.dp failed with error -22Wouldn't it make more sense to simply not enable the DisplayPort node in the upstream DT, until the type-C phy work has been done to make it usable at all?
Or alternatively just disable the cdn-dp Rockchip driver in the kernel config, which results in it also not getting probed.
Quoted 34 lines
AIUI the "official" Manjaro kernel is carrying a bunch of hacks to make type-C work via extcon, but they know that isn't an upstreamable solution.
Robin.
Quoted 28 lines
Then, the device halts all of the DRM related device jobs. For example, the operations:
vop_component_ops,vop_component_opsandrockchip_dp_component_opscannot be bound to corresponding devices. So, Xorg cannot find the correct DRM device.This patch skips the probing failed devices to fix this issue.
Signed-off-by Jian-Hong Pan <[email protected]>--- drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 6 ++++++ 1 file changed, 6 insertions(+)drivers/gpu/drm/rockchip/rockchip_drm_drv.c +6
-0@@ -331,6 +331,12 @@ static struct component_match *rockchip_drm_match_add(struct device *dev)if (!d)break ; +if (!d->driver) { +DRM_DEV_ERROR (d, +"%s did not probe successfully" , + drv->driver.name); +continue ; + }
Quoted 4 lines
drivers/gpu/drm/rockchip/rockchip_drm_drv.c static struct component_match *rockchip_drm_match_add(struct device *dev) · line 342
Quoted 3 lines
drivers/gpu/drm/rockchip/rockchip_drm_drv.c +0
-0device_link_add (dev, d,DL_FLAG_STATELESS );component_match_add (dev, &match, compare_dev, d);
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH] drm/rockchip: skip probed failed device
Heiko Stübner <[email protected]> 於 2020年9月23日 週三 下午7:16寫道:
Quoted 8 lines
Am Mittwoch, 23. September 2020, 13:05:26 CEST schrieb Robin Murphy:
Quoted 6 lines · Jian-Hong Pan
Quoted 4 lines
The cdn-dp sub driver probes the device failed on PINEBOOK Pro.
kernel: cdn-dp fec00000.dp: [drm:cdn_dp_probe [rockchipdrm]] *ERROR* missing extcon or phy
kernel: cdn-dp: probe of fec00000.dp failed with error -22
Quoted 6 lines
Quoted 3 lines
Wouldn't it make more sense to simply not enable the DisplayPort node in the upstream DT, until the type-C phy work has been done to make it usable at all?
Or alternatively just disable the cdn-dp Rockchip driver in the kernel config, which results in it also not getting probed.
This may be the simplest way.
However, considering generic distro kernels have a policy to enable all drivers, disabling the DisplayPort node in the upstream DT, until the type-C phy work has been done may be a better solution for now. I can prepare a patch for this.
Jian-Hong Pan
Quoted 36 lines
Quoted 36 lines
AIUI the "official" Manjaro kernel is carrying a bunch of hacks to make type-C work via extcon, but they know that isn't an upstreamable solution.
Robin.
Quoted 30 lines
Then, the device halts all of the DRM related device jobs. For example, the operations:
vop_component_ops,vop_component_opsandrockchip_dp_component_opscannot be bound to corresponding devices. So, Xorg cannot find the correct DRM device.This patch skips the probing failed devices to fix this issue.
Signed-off-by Jian-Hong Pan <[email protected]>--- drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 6 ++++++ 1 file changed, 6 insertions(+)drivers/gpu/drm/rockchip/rockchip_drm_drv.c +6
-0@@ -331,6 +331,12 @@ static struct component_match *rockchip_drm_match_add(struct device *dev)if (!d)break ; +if (!d->driver) { +DRM_DEV_ERROR (d, +"%s did not probe successfully" , + drv->driver.name); +continue ; + }device_link_add (dev, d,DL_FLAG_STATELESS );component_match_add (dev, &match, compare_dev, d);