Skip to contentSkip to conversation

: Fix NAT init order

PATCH In review Patrick McHardy 2 participants 2 messages Dec 19, 2005

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/2 : Fix NAT init order

Hi Dave,

following are two simple bugfixes which should go in 2.6.15 if possible.

[NETFILTER]: Fix NAT init order

As noticed by Phil Oester, the GRE NAT protocol helper is initialized before the NAT core, which makes registration fail.

Change the linking order to make NAT be initialized first.

---
commit 87704c86b3406255a2b68b1d1a68ff72baa6177e
tree 349f73319574ccb3a02acaefab7cec8edaa798f6
parent afe1ec2b866d310f47db2f368f1f4a7b4961ffed
author Patrick McHardy <[email protected]> Mon, 19 Dec 2005 11:17:20 +0100 committer Patrick McHardy <[email protected]> Mon, 19 Dec 2005 11:17:20 +0100

 net/ipv4/netfilter/Makefile |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
net/ipv4/netfilter/Makefile +2 -1
index 058c48e..d0a447e 100644
@@ -12,6 +12,7 @@ ip_nat_pptp-objs	:= ip_nat_helper_pptp.o
 
 # connection tracking
 obj-$(CONFIG_IP_NF_CONNTRACK) += ip_conntrack.o
+obj-$(CONFIG_IP_NF_NAT) += ip_nat.o
 
 # conntrack netlink interface
 obj-$(CONFIG_IP_NF_CONNTRACK_NETLINK) += ip_conntrack_netlink.o
@@ -41,7 +42,7 @@ obj-$(CONFIG_IP_NF_IPTABLES) += ip_table
 # the three instances of ip_tables
 obj-$(CONFIG_IP_NF_FILTER) += iptable_filter.o
 obj-$(CONFIG_IP_NF_MANGLE) += iptable_mangle.o
-obj-$(CONFIG_IP_NF_NAT) += iptable_nat.o ip_nat.o
+obj-$(CONFIG_IP_NF_NAT) += iptable_nat.o
 obj-$(CONFIG_IP_NF_RAW) += iptable_raw.o
 
 # matches
maintainer
#1 lore raw

From: Patrick McHardy <[email protected]>
Date: Mon, 19 Dec 2005 11:21:48 +0100

Quoted 2 lines

following are two simple bugfixes which should go in 2.6.15 if possible.

Both applied, thanks a lot.