Skip to contentSkip to conversation

s3c2410fb: cleanup and fix

PATCH New Antonino A. Daplas 1 participant 1 message Dec 21, 2005

Subsystems (2)
Framebuffer layer Arm Samsung Exynos
lore
Share & tools
lore

Antonino A. Daplas

author
#0 lore raw

PATCH 5/9 s3c2410fb: cleanup and fix

From: Arnaud Patard <[email protected]>

Here are some cleanups for the s3c2410fb drivers. It :
* Removes a buggy call to s3c2410fb_init_registers. There was two calls to this function but the first was done without all initialisations done. No oops but it may confuse some LCDs.
* Makes two functions static.

Signed-off-by Arnaud Patard <[email protected]>
Signed-off-by Antonino Daplas <[email protected]>

---

 drivers/video/s3c2410fb.c |   10 ++++------
 1 files changed, 4 insertions(+), 6 deletions(-)
drivers/video/s3c2410fb.c +4 -6
index ce6e749..1ff78cb 100644
@@ -552,7 +552,7 @@ static inline void modify_gpio(void __io
  * s3c2410fb_init_registers - Initialise all LCD-related registers
  */
 
-int s3c2410fb_init_registers(struct s3c2410fb_info *fbi)
+static int s3c2410fb_init_registers(struct s3c2410fb_info *fbi)
 {
 	unsigned long flags;
 

@@ -634,7 +634,7 @@ static irqreturn_t s3c2410fb_irq(int irq
 
 static char driver_name[]="s3c2410fb";
 
-int __init s3c2410fb_probe(struct platform_device *pdev)
+static int __init s3c2410fb_probe(struct platform_device *pdev)
 {
 	struct s3c2410fb_info *info;
 	struct fb_info	   *fbinfo;

@@ -667,8 +667,6 @@ int __init s3c2410fb_probe(struct platfo
 	info->fb = fbinfo;
 	platform_set_drvdata(pdev, fbinfo);
 
-	s3c2410fb_init_registers(info);
-
 	dprintk("devinit\n");
 
 	strcpy(fbinfo->fix.id, driver_name);

@@ -701,8 +699,8 @@ int __init s3c2410fb_probe(struct platfo
 	fbinfo->var.yres_virtual    = mach_info->yres.defval;
 	fbinfo->var.bits_per_pixel  = mach_info->bpp.defval;
 
-	fbinfo->var.upper_margin    = S3C2410_LCDCON2_GET_VBPD(mregs->lcdcon2) +1;
-	fbinfo->var.lower_margin    = S3C2410_LCDCON2_GET_VFPD(mregs->lcdcon2) +1;
+	fbinfo->var.upper_margin    = S3C2410_LCDCON2_GET_VBPD(mregs->lcdcon2) + 1;
+	fbinfo->var.lower_margin    = S3C2410_LCDCON2_GET_VFPD(mregs->lcdcon2) + 1;
 	fbinfo->var.vsync_len	    = S3C2410_LCDCON2_GET_VSPW(mregs->lcdcon2) + 1;
 
 	fbinfo->var.left_margin	    = S3C2410_LCDCON3_GET_HFPD(mregs->lcdcon3) + 1;

-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files for problems? Stop! Download the new AJAX search engine that makes searching your log files as easy as surfing the web. DOWNLOAD SPLUNK!
http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click