Skip to contentSkip to conversation

Remove unneeded packed attribute

PATCH In review Brian Gerst 2 participants 2 messages Dec 28, 2005

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Remove unneeded packed attribute

GCC 4.1 gives the following warning:
include/asm/mpspec.h:79: warning: ‘packed’ attribute ignored for field of type ‘unsigned char[5u]’

The packed attribute isn't really necessary anyways so just remove it.

[PATCH] Remove unneeded packed attribute

GCC 4.1 gives the following warning:
include/asm/mpspec.h:79: warning: ‘packed’ attribute ignored for field of type ‘unsigned char[5u]’

The packed attribute isn't really necessary anyways so just remove it.

---
commit 58c5813206aec0df47a061ad31c457cd6e176d12
tree 2b900ac50c67c30f87115b1a9f752f9f2e871556
parent 9a4863865f6c539b799adf0f41de862a7163d819
author Brian Gerst <[email protected]> Tue, 27 Dec 2005 18:48:21 -0500 committer Brian Gerst <[email protected]> Tue, 27 Dec 2005 18:48:21 -0500

 include/asm-i386/mpspec_def.h |    2 +-
 include/asm-x86_64/mpspec.h   |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
include/asm-i386/mpspec_def.h +1 -1
index a961093..76feedf 100644
@@ -75,7 +75,7 @@ struct mpc_config_bus
 {
 	unsigned char mpc_type;
 	unsigned char mpc_busid;
-	unsigned char mpc_bustype[6] __attribute((packed));
+	unsigned char mpc_bustype[6];
 };
 
 /* List of Bus Type string values, Intel MP Spec. */
include/asm-x86_64/mpspec.h +1 -1
index 6f8a17d..10248a9 100644
@@ -76,7 +76,7 @@ struct mpc_config_bus
 {
 	unsigned char mpc_type;
 	unsigned char mpc_busid;
-	unsigned char mpc_bustype[6] __attribute((packed));
+	unsigned char mpc_bustype[6];
 };
 
 /* List of Bus Type string values, Intel MP Spec. */
#1 lore raw
Quoted 7 lines · Brian Gerst

GCC 4.1 gives the following warning:
include/asm/mpspec.h:79: warning: ‘packed’ attribute ignored for field of type ‘unsigned char[5u]’

The packed attribute isn't really necessary anyways so just remove it.

We've been carrying exactly the same diff in the Fedora rawhide kernel for the last week or two.

ACKed by: Dave Jones <[email protected]>

Dave