Skip to contentSkip to conversation

fix tracer compilation issues

PATCH In review Jan Kiszka 2 participants 2 messages Jan 8, 2006 – Jan 9, 2006

lore
Share & tools
lore

Jan Kiszka

author
#0 lore raw

PATCH 1/1 fix tracer compilation issues

Hi Philippe,

two minor updates I fixed since your last merge. The first one triggers if the tracer tries to warn of debugging switch related latencies. The second one when building very specific out-of-tree modules against the kernel (here: madwifi with its binary-only component), stumbling over -pg vs. -fomit-frame-pointer.

No need for a separate ipipe release from my POV, just apply for the next round.

Jan

kernel/ipipe/tracer.c renamed from kernel/ipipe/tracer.c.orig +1 -1
@@ -821,7 +821,7 @@ static void *__ipipe_frozen_prtrace_star
 			"------------------------------------------------------"
 			"------\n",
 			UTS_RELEASE, IPIPE_ARCH_STRING);
-		__ipipe_print_dbgwarning();
+		__ipipe_print_dbgwarning(m);
 		seq_printf(m, "Freeze: %lld cycles, Trace Points: %d (+%d)\n\n",
 			print_path->point[print_path->begin].timestamp,
 			print_pre_trace+1, print_post_trace);
kernel/ipipe/Kconfig renamed from kernel/ipipe/Kconfig.orig +1 -0
@@ -17,6 +17,7 @@ config IPIPE_STATS
 config IPIPE_TRACE
  	bool "Latency Tracing"
 	depends on IPIPE && PROC_FS
+	select FRAME_POINTER
 	default n
 	---help---
 	  Activate this option if you want to use per-function tracing of
#1 lore raw
Quoted 11 lines · Jan Kiszka

Hi Philippe,

two minor updates I fixed since your last merge. The first one triggers if the tracer tries to warn of debugging switch related latencies. The second one when building very specific out-of-tree modules against the kernel (here: madwifi with its binary-only component), stumbling over -pg vs. -fomit-frame-pointer.

No need for a separate ipipe release from my POV, just apply for the next round.

Ok, queued. Thanks.

Quoted 26 lines

Jan

------------------------------------------------------------------------

kernel/ipipe/tracer.c renamed from kernel/ipipe/tracer.c.orig +1 -1
@@ -821,7 +821,7 @@ static void *__ipipe_frozen_prtrace_star
 			"------------------------------------------------------"
 			"------\n",
 			UTS_RELEASE, IPIPE_ARCH_STRING);
-		__ipipe_print_dbgwarning();
+		__ipipe_print_dbgwarning(m);
 		seq_printf(m, "Freeze: %lld cycles, Trace Points: %d (+%d)\n\n",
 			print_path->point[print_path->begin].timestamp,
 			print_pre_trace+1, print_post_trace);
kernel/ipipe/Kconfig renamed from kernel/ipipe/Kconfig.orig +1 -0
@@ -17,6 +17,7 @@ config IPIPE_STATS
 config IPIPE_TRACE
  	bool "Latency Tracing"
 	depends on IPIPE && PROC_FS
+	select FRAME_POINTER
 	default n
 	---help---
 	  Activate this option if you want to use per-function tracing of
Signature · 1 line
Philippe.