Skip to contentSkip to conversation

Fix memory allocation bug - take two

ULOG Applied Holger Eitzenberger 2 participants 3 messages Jan 18, 2006

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

Hi,

this is resend of my previous patch which fixes a bug in the way ULOG does allocate memory. It uses NLMSG_GOODSIZE to portably determine the size of 'nlbufsiz'. Thanks Patrick!

Please apply.

Thanks. /holger

#1 lore raw

PATCH 1/1 Use better value for 'nlbufsiz'

Performance tests showed that ULOG may fail on heavy loaded systems because of failed order-N allocations (N >= 1).

The default value of 4096 is not optimal in the sense that it actually allocates _two_ contigous physical pages. Reasoning: ULOG uses alloc_skb(), which adds another ~300 bytes for skb_shared_info.

This patch sets the default value to NLMSG_GOODSIZE and adds some documentation at the top.

---

 net/ipv4/netfilter/ipt_ULOG.c |    6 +++++-
 1 files changed, 5 insertions(+), 1 deletions(-)

d07d41421fb31a3759f66e41ebaea204c5d4146c

net/ipv4/netfilter/ipt_ULOG.c +5 -1
index 641dbc4..2fe6413 100644
@@ -35,6 +35,10 @@
  * each nlgroup you are using, so the total kernel memory usage increases
  * by that factor.
  *
+ * Actually you should use nlbufsiz a bit smaller than PAGE_SIZE, since
+ * nlbufsiz is used with alloc_skb, which adds another
+ * sizeof(struct skb_shared_info).  Use NLMSG_GOODSIZE instead.
+ *
  * flushtimeout:
  *   Specify, after how many hundredths of a second the queue should be
  *   flushed even if it is not full yet.
@@ -76,7 +80,7 @@ MODULE_ALIAS_NET_PF_PROTO(PF_NETLINK, NE
 
 #define PRINTR(format, args...) do { if (net_ratelimit()) printk(format , ## args); } while (0)
 
-static unsigned int nlbufsiz = 4096;
+static unsigned int nlbufsiz = NLMSG_GOODSIZE;
 module_param(nlbufsiz, uint, 0400);
 MODULE_PARM_DESC(nlbufsiz, "netlink buffer size");
 
Signature · 1 line
1.0.GIT
#2 lore raw

Re: [PATCH] [ULOG] Use better value for 'nlbufsiz'

Quoted 9 lines · Holger Eitzenberger

Performance tests showed that ULOG may fail on heavy loaded systems because of failed order-N allocations (N >= 1).

The default value of 4096 is not optimal in the sense that it actually allocates _two_ contigous physical pages. Reasoning: ULOG uses alloc_skb(), which adds another ~300 bytes for skb_shared_info.

This patch sets the default value to NLMSG_GOODSIZE and adds some documentation at the top.

Applied, thanks Holger.