Skip to contentSkip to conversation

lm93 driver for 2.6, third try [0/2]

PATCH New Eric J. Bowersox 4 participants 7 messages Aug 4, 2005 – Jan 27, 2006

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 lm93 driver for 2.6, third try [0/2]

After a go-round on the last one, and a round of testing, herewith is the LM93 driver patch for 2.6, third try.

This is now actually two separate patches, both against 2.6.13-rc3-mm3. The first is i2cblock-2.6.13-rc3-mm3.patch, which reintroduces the i2c_smbus_read_block_data function into i2c-core, because the lm93 driver needs it. (The code was lifted from the 2.6.5 version of drivers/i2c/i2c-core.c.) The second is lm93-driver-2.6.13-rc3-mm3.patch, the actual driver, which now depends on that first patch.

On a system with a Supermicro X6DHP motherboard, running SuSE Linux Enterprise Server 9, the 2.6.13-rc3-mm3 kernel plus these two patches, and lm_sensors 2.9.1, the lm93 driver now reports fully valid voltages, temperatures, and fan speeds, *without* requiring the disable_block=1 parameter. So it's good now from a functional standpoint, at least as far as we're concerned.

Patches to follow.

Eric

Signature · 4 lines
Eric J. Bowersox, Software Engineer     Aspen Systems, Inc.
<[email protected]>                      3900 Youngfield Street
Tel: +01 303 431 4606 x113              Wheat Ridge, CO  80033, USA
Fax: +01 303 431 7196                   <http://www.aspsys.com>
#1 lore raw

PATCH 1/1 lm93 driver for 2.6, third try [1/2]

This is i2cblock-2.6.13-rc3-mm3.patch, against 2.6.13-rc3-mm3, which reintroduces the i2c_smbus_read_block_data function into i2c-core, because the lm93 driver needs it.

Signature · 11 lines
Eric J. Bowersox, Software Engineer     Aspen Systems, Inc.
<[email protected]>                      3900 Youngfield Street
Tel: +01 303 431 4606 x113              Wheat Ridge, CO  80033, USA
Fax: +01 303 431 7196                   <http://www.aspsys.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: i2cblock-2.6.13-rc3-mm3.patch
Type: text/x-patch
Size: 1872 bytes
Desc: not available
Url : http://lists.lm-sensors.org/pipermail/lm-sensors/attachments/20050804/2c916c0a/i2cblock-2.6.13-rc3-mm3-0001.bin
#2 lore raw

PATCH 1/1 lm93 driver for 2.6, third try [2/2]

In reply to Eric J. Bowersox

This is lm93-driver-2.6.13-rc3-mm3.patch, against 2.6.13-rc3-mm3, which implements the National Semiconductor LM93 hardware monitoring driver. It depends on the i2cblock-2.6.13-rc3-mm3.patch patch.

Signature · 11 lines
Eric J. Bowersox, Software Engineer     Aspen Systems, Inc.
<[email protected]>                      3900 Youngfield Street
Tel: +01 303 431 4606 x113              Wheat Ridge, CO  80033, USA
Fax: +01 303 431 7196                   <http://www.aspsys.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: lm93-driver-2.6.13-rc3-mm3.patch
Type: text/x-patch
Size: 96467 bytes
Desc: not available
Url : http://lists.lm-sensors.org/pipermail/lm-sensors/attachments/20050804/7daccecd/lm93-driver-2.6.13-rc3-mm3-0001.bin
#3 lore raw

PATCH 1/1 lm93 driver for 2.6, third try [1/2]

In reply to Eric J. Bowersox

Hi Eric,

[Eric J. Bowersox]

Quoted 3 lines

This is i2cblock-2.6.13-rc3-mm3.patch, against 2.6.13-rc3-mm3, which reintroduces the i2c_smbus_read_block_data function into i2c-core, because the lm93 driver needs it.

I'm of course fine with the reintroduction of a standard smbus function you need, but I'd like you to fix formal issues this patch has:

* Please place the i2c_smbus_read_block_data function (and declarations) before i2c_smbus_write_block_data rather than after. All other pairs have read before write.

* There should be one space after each comma (except at line end). I know the original code you took from 2.6.5 wasn't correct in this respect, but as we are adding it back now, let's do it with standard coding style.

Can you please send an updated patch addressing these points?

Thanks,
--
Jean Delvare

#4 lore raw

PATCH 1/1 lm93 driver for 2.6, third try [1/2]

In reply to Eric J. Bowersox
Quoted 7 lines · Jean Delvare

I'm of course fine with the reintroduction of a standard smbus function you need, but I'd like you to fix formal issues this patch has:

* Please place the i2c_smbus_read_block_data function (and declarations) before i2c_smbus_write_block_data rather than after. All other pairs have read before write.

Quoted 6 lines

* There should be one space after each comma (except at line end). I know the original code you took from 2.6.5 wasn't correct in this respect, but as we are adding it back now, let's do it with standard coding style.

Can you please send an updated patch addressing these points?

All right. Herewith an update of the patch i2cblock-2.6.13-rc3-mm3.patch, which fixes the ordering (of the function code as well as the header file and EXPORT_SYMBOL declarations) and the comma spacing. As with the previous version of this patch, it reintroduces the function i2c_smbus_read_block_data to i2c-core, as it is needed by the lm93 driver.

Eric

Signature · 11 lines
Eric J. Bowersox, Software Engineer     Aspen Systems, Inc.
<[email protected]>                      3900 Youngfield Street
Tel: +01 303 431 4606 x113              Wheat Ridge, CO  80033, USA
Fax: +01 303 431 7196                   <http://www.aspsys.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: i2cblock-2.6.13-rc3-mm3.patch
Type: text/x-patch
Size: 1943 bytes
Desc: not available
Url : http://lists.lm-sensors.org/pipermail/lm-sensors/attachments/20050804/bd9a6a23/i2cblock-2.6.13-rc3-mm3.bin