hamradio/bpqether.c: check return value of
Subsystems (2)
check the return value of register_netdevice_notifier()
also as attachment if something mangels the layout. compile tested
Signed-off-by walter harms <[email protected]>
drivers/net/hamradio/bpqether.c renamed from drivers/net/hamradio/bpqether.c.bak +7 -1
@@ -595,6 +595,7 @@*/ static int __init bpq_init_driver (void ) { +int ret;#ifdef CONFIG_PROC_FS if (!proc_net_fops_create ("bpqether" ,S_IRUGO , &bpq_info_fops)) { printk(KERN_ERR
@@ -605,7 +606,12 @@dev_add_pack (&bpq_packet_type); -register_netdevice_notifier (&bpq_dev_notifier); + ret =register_netdevice_notifier (&bpq_dev_notifier); +if (ret <0 ) { +printk (KERN_WARNING "register_netdevice_notifier failed in %s\n" ,__FUNCTION__); +dev_remove_pack (&bpq_packet_type); +return -1 ; + }printk (banner);
drivers/net/hamradio/bpqether.c renamed from drivers/net/hamradio/bpqether.c.bak +7 -1
@@ -595,6 +595,7 @@*/ static int __init bpq_init_driver (void ) { +int ret;#ifdef CONFIG_PROC_FS if (!proc_net_fops_create ("bpqether" ,S_IRUGO , &bpq_info_fops)) { printk(KERN_ERR
@@ -605,7 +606,12 @@dev_add_pack (&bpq_packet_type); -register_netdevice_notifier (&bpq_dev_notifier); + ret =register_netdevice_notifier (&bpq_dev_notifier); +if (ret <0 ) { +printk (KERN_WARNING "register_netdevice_notifier failed in %s\n" ,__FUNCTION__); +dev_remove_pack (&bpq_packet_type); +return -1 ; + }printk (banner);
_______________________________________________
Kernel-janitors mailing list
[email protected]
https://lists.osdl.org/mailman/listinfo/kernel-janitors
Quoted 11 lines
drivers/net/hamradio/bpqether.c renamed from drivers/net/hamradio/bpqether.c.bak +1
-0@@ -595,6 +595,7 @@*/ static int __init bpq_init_driver (void ) { +int ret;#ifdef CONFIG_PROC_FS if (!proc_net_fops_create ("bpqether" ,S_IRUGO , &bpq_info_fops)) { printk(KERN_ERR
drivers/net/hamradio/bpqether.c line 614
Quoted 10 lines
drivers/net/hamradio/bpqether.c renamed from drivers/net/hamradio/bpqether.c.bak +6
-1@@ -605,7 +606,12 @@dev_add_pack (&bpq_packet_type); -register_netdevice_notifier (&bpq_dev_notifier); + ret =register_netdevice_notifier (&bpq_dev_notifier); +if (ret <0 ) { +printk (KERN_WARNING "register_netdevice_notifier failed in %s\n" ,__FUNCTION__); +dev_remove_pack (&bpq_packet_type); +return -1 ; + }
Looks good except proc_net_fops_create() should be reversed, KERN_ERR, and not return -1 always.
_______________________________________________
Kernel-janitors mailing list
[email protected]
https://lists.osdl.org/mailman/listinfo/kernel-janitors