cassini compwb fixup
hi list,
this is a problem that only the author can resolve. perhaps this is used in some embedded system or so. I would advise to fix the obvious problem before removing since this may break an otherwise working driver.
re,
walter
Quoted 16 lines · Alexey Dobriyan
Quoted 4 lines
drivers/net/cassini.c: fix undefined variableWe had a discussion about %L vs %ll in cassini but we agreed that you will change %L into %ll so perhaps that went an other way.
Warnings were fixed since then. I wonder if driver is used with
USE_TX_COMPWBundefined. If not #ifdefs should be removed. Also we may stop printing after status and not print 0 at all.drivers/net/cassini.c +0
-0@@ -1946,10 +1946,11 @@ static inline void cas_tx_ringN(struct cstatic void cas_tx (struct net_device *dev,struct cas *cp,u32 status)
drivers/net/cassini.c static inline void cas_tx_ringN(struct c · line 1956
Quoted 10 lines
drivers/net/cassini.c +2
-1{int limit, ring; +u64 compwb =0 ;#ifdef USE_TX_COMPWB -u64 compwb =le64_to_cpu (cp->init_block->tx_compwb); + compwb =le64_to_cpu (cp->init_block->tx_compwb);#endif if (netif_msg_intr (cp))printk (KERN_DEBUG "%s: tx interrupt, status: 0x%x, %llx\n" , cp->dev->name, status, (unsigned long long )compwb);
_______________________________________________
Kernel-janitors mailing list
[email protected]
https://lists.osdl.org/mailman/listinfo/kernel-janitors