Skip to contentSkip to conversation

+ isdn4linux-siemens-gigaset-drivers-common-module.patch added to -mm tree

DISCUSSION Arjan van de Ven 2 participants 2 messages Feb 12, 2006 – Feb 15, 2006 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw
Quoted 18 lines · On Sun, 2006-02-12 at 02:31 -0800, [email protected] wrote:

The patch titled

isdn4linux: Siemens Gigaset drivers - common module

has been added to the -mm tree. Its filename is

isdn4linux-siemens-gigaset-drivers-common-module.patch

See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find out what to do about this

From: Hansjoerg Lipp <[email protected]>

And: Tilman Schmidt <[email protected]>

Review

Quoted 6 lines
(quoted diff) +6 -0
+struct prot_skb {
+	atomic_t		empty;
+	struct semaphore	*sem;
+	struct sk_buff		*skb;
+};
+

please consider using mutexes instead!

#2 lore raw
Quoted 8 lines · Arjan van de Ven

Review

Quoted 6 lines
(quoted diff) +5 -0
+struct prot_skb {
+	atomic_t		empty;
+	struct semaphore	*sem;
+	struct sk_buff		*skb;
+};

please consider using mutexes instead!

Thanks for the hint. As you may have guessed, the driver dates from pre-mutex times. :-) However, this structure is currently unused, anyway, so we'll just remove it and recreate it with a mutex should we need it again.

Regards
Tilman

Signature · 4 lines
Tilman Schmidt                          E-Mail: [email protected]
Bonn, Germany
Diese Nachricht besteht zu 100% aus wiederverwerteten Bits.
Ungeöffnet mindestens haltbar bis: (siehe Rückseite)