Skip to contentSkip to conversation

CONFIG_CPU_FREQ

PATCH New Petersson, Mats 4 participants 4 messages Feb 15, 2006 – Feb 20, 2006

lore
Share & tools
lore
#0 lore raw
Quoted 20 lines

-----Original Message-----
From: [email protected] [mailto:[email protected]] On Behalf Of Jan Beulich
Sent: 15 February 2006 14:06
To: [email protected]
Subject: [Xen-devel] CONFIG_CPU_FREQ

I see that linux-defconfig-xen{,0}_x86_32 have CONFIG_CPU_FREQ disabled, presumably since these are not expected to work (and in fact some of the resulting modules don't have all the symbols they depend upon available). Can someone confirm this? We have this and the dependent options still enabled in our SLES10 kernels, and I'd like to know whether I should try to fix the missing symbols problem, or whether instead CPU_FREQ should be made dependent upon !X86_XEN (similar to how x86-64 does).

Quoted 2 lines

Thanks, Jan

CPU frequency changing doesn't work under Xen at the moment, and it's pretty pointless for individual kernels to do this without understanding what else is going on in the OTHER kernels that may be running on the system - so it makes sense to disable it by "permanent" measure, until someone gets round to figuring out how to make Xen itself handle CPU frequency changing (perhaps with help from Dom0)...

--
Mats

#1 lore raw

PATCH 1/1 i386 linux: RE: CONFIG_CPU_FREQ

Patch conditionalizing the option attached.

Quoted 21 lines
Quoted 1 line
Quoted 1 line

"Petersson, Mats" <[email protected]> 15.02.06 15:10:55 >>>

-----Original Message-----
From: [email protected] [mailto:[email protected]] On Behalf Of Jan Beulich
Sent: 15 February 2006 14:06
To: [email protected]
Subject: [Xen-devel] CONFIG_CPU_FREQ

I see that linux-defconfig-xen{,0}_x86_32 have CONFIG_CPU_FREQ disabled, presumably since these are not expected to work (and in fact some of the resulting modules don't have all the symbols they depend upon available). Can someone confirm this? We have this and the dependent options still enabled in our SLES10 kernels, and I'd like to know whether I should try to fix the missing symbols problem, or whether instead CPU_FREQ should be made dependent upon !X86_XEN (similar to how x86-64 does).

Quoted 2 lines

Thanks, Jan

CPU frequency changing doesn't work under Xen at the moment, and it's pretty pointless for individual kernels to do this without understanding what else is going on in the OTHER kernels that may be running on the system - so it makes sense to disable it by "permanent" measure, until someone gets round to figuring out how to make Xen itself handle CPU frequency changing (perhaps with help from Dom0)...

--
Mats

_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xensource.com/xen-devel

arch/i386/Kconfig +2 -0
Index: head-2006-02-14/arch/i386/Kconfig
===================================================================
@@ -946,7 +946,9 @@ config APM_REAL_MODE_POWER_OFF
 
 endmenu
 
+if !X86_XEN
 source "arch/i386/kernel/cpu/cpufreq/Kconfig"
+endif
 
 endmenu
 

_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xensource.com/xen-devel

#2 lore raw
In reply to Petersson, Mats
Quoted 6 lines · Mats

CPU frequency changing doesn't work under Xen at the moment, and it's pretty pointless for individual kernels to do this without understanding what else is going on in the OTHER kernels that may be running on the system - so it makes sense to disable it by "permanent" measure, until someone gets round to figuring out how to make Xen itself handle CPU frequency changing (perhaps with help from Dom0)...

I could be insane, but I'm pretty sure it works at least in dom0 right now. So disabling it across the board means a loss of functionality for anyone wanting to run dom0 on their laptop which isn't really needed.

Having it dependent on either XEN_PHYSDEV_ACCESS or XEN_PRIVILEGED_GUEST, on the other hand, doesn't seem unreasonable

Jeremy

#3 lore raw
Quoted 6 lines · Jeremy Katz

I could be insane, but I'm pretty sure it works at least in dom0 right now. So disabling it across the board means a loss of functionality for anyone wanting to run dom0 on their laptop which isn't really needed.

Having it dependent on either XEN_PHYSDEV_ACCESS or XEN_PRIVILEGED_GUEST, on the other hand, doesn't seem unreasonable

It is already dependent on !XEN_UNPRIVILEGED_GUEST on i386, I've changed x86_64 to match.

christian