Skip to contentSkip to conversation

liquidio: Fix -Wmissing-prototypes warnings for liquidio

PATCH Applied Wang Hai 3 participants 3 messages Sep 18, 2020

Subsystems (3)
lore
Share & tools
lore

Wang Hai

author
#0 lore raw

PATCH 1/1 liquidio: Fix -Wmissing-prototypes warnings for liquidio

If the header file containing a function's prototype isn't included by the sourcefile containing the associated function, the build system complains of missing prototypes.

Fixes the following W=1 kernel build warning(s):

drivers/net/ethernet/cavium/liquidio/cn68xx_device.c:124:5: warning: no previous prototype for ‘lio_setup_cn68xx_octeon_device’ [-Wmissing-prototypes] drivers/net/ethernet/cavium/liquidio/octeon_mem_ops.c:159:1: warning: no previous prototype for ‘octeon_pci_read_core_mem’ [-Wmissing-prototypes] drivers/net/ethernet/cavium/liquidio/octeon_mem_ops.c:168:1: warning: no previous prototype for ‘octeon_pci_write_core_mem’ [-Wmissing-prototypes] drivers/net/ethernet/cavium/liquidio/octeon_mem_ops.c:176:5: warning: no previous prototype for ‘octeon_read_device_mem64’ [-Wmissing-prototypes] drivers/net/ethernet/cavium/liquidio/octeon_mem_ops.c:185:5: warning: no previous prototype for ‘octeon_read_device_mem32’ [-Wmissing-prototypes] drivers/net/ethernet/cavium/liquidio/octeon_mem_ops.c:194:6: warning: no previous prototype for ‘octeon_write_device_mem32’ [-Wmissing-prototypes]

---
 drivers/net/ethernet/cavium/liquidio/cn68xx_device.c  | 1 +
 drivers/net/ethernet/cavium/liquidio/octeon_mem_ops.c | 1 +
 2 files changed, 2 insertions(+)
drivers/net/ethernet/cavium/liquidio/cn68xx_device.c +1 -0
index 50b533ff58e6..cd5d5d6e7e5e 100644
@@ -26,6 +26,7 @@
 #include "cn66xx_regs.h"
 #include "cn66xx_device.h"
 #include "cn68xx_regs.h"
+#include "cn68xx_device.h"
 
 static void lio_cn68xx_set_dpi_regs(struct octeon_device *oct)
 {
drivers/net/ethernet/cavium/liquidio/octeon_mem_ops.c +1 -0
index 4c85ae643b7b..7ccab36143c1 100644
@@ -22,6 +22,7 @@
 #include "octeon_iq.h"
 #include "response_manager.h"
 #include "octeon_device.h"
+#include "octeon_mem_ops.h"
 
 #define MEMOPS_IDX   BAR1_INDEX_DYNAMIC_MAP
 
Signature · 1 line
2.17.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 26 lines · Wang Hai

If the header file containing a function's prototype isn't included by
the sourcefile containing the associated function, the build system complains of missing prototypes.

Fixes the following W=1 kernel build warning(s):

drivers/net/ethernet/cavium/liquidio/cn68xx_device.c:124:5: warning:
no previous prototype for ‘lio_setup_cn68xx_octeon_device’ [- Wmissing-prototypes] drivers/net/ethernet/cavium/liquidio/octeon_mem_ops.c:159:1: warning:
no previous prototype for ‘octeon_pci_read_core_mem’ [-Wmissing- prototypes] drivers/net/ethernet/cavium/liquidio/octeon_mem_ops.c:168:1: warning:
no previous prototype for ‘octeon_pci_write_core_mem’ [-Wmissing- prototypes] drivers/net/ethernet/cavium/liquidio/octeon_mem_ops.c:176:5: warning:
no previous prototype for ‘octeon_read_device_mem64’ [-Wmissing- prototypes] drivers/net/ethernet/cavium/liquidio/octeon_mem_ops.c:185:5: warning:
no previous prototype for ‘octeon_read_device_mem32’ [-Wmissing- prototypes] drivers/net/ethernet/cavium/liquidio/octeon_mem_ops.c:194:6: warning:
no previous prototype for ‘octeon_write_device_mem32’ [-Wmissing- prototypes]

Quoted 2 lines
maintainer Applied
#2 lore raw
In reply to Wang Hai

From: Wang Hai <[email protected]>
Date: Fri, 18 Sep 2020 21:02:10 +0800

Quoted 6 lines

If the header file containing a function's prototype isn't included by the sourcefile containing the associated function, the build system complains of missing prototypes.

Fixes the following W=1 kernel build warning(s):

Quoted 8 lines

drivers/net/ethernet/cavium/liquidio/cn68xx_device.c:124:5: warning: no previous prototype for ‘lio_setup_cn68xx_octeon_device’ [-Wmissing-prototypes] drivers/net/ethernet/cavium/liquidio/octeon_mem_ops.c:159:1: warning: no previous prototype for ‘octeon_pci_read_core_mem’ [-Wmissing-prototypes] drivers/net/ethernet/cavium/liquidio/octeon_mem_ops.c:168:1: warning: no previous prototype for ‘octeon_pci_write_core_mem’ [-Wmissing-prototypes] drivers/net/ethernet/cavium/liquidio/octeon_mem_ops.c:176:5: warning: no previous prototype for ‘octeon_read_device_mem64’ [-Wmissing-prototypes] drivers/net/ethernet/cavium/liquidio/octeon_mem_ops.c:185:5: warning: no previous prototype for ‘octeon_read_device_mem32’ [-Wmissing-prototypes] drivers/net/ethernet/cavium/liquidio/octeon_mem_ops.c:194:6: warning: no previous prototype for ‘octeon_write_device_mem32’ [-Wmissing-prototypes]

Applied.