thermal/drivers/u8500: Remove unnecessary print function dev_err()
PATCH 1/1 thermal/drivers/u8500: Remove unnecessary print function dev_err()
The print function dev_err() is redundant because platform_get_irq() already prints an error.
Eliminate the follow coccicheck warnings:
./drivers/thermal/db8500_thermal.c:162:2-9: line 162 is redundant because platform_get_irq() already prints an error ./drivers/thermal/db8500_thermal.c:176:2-9: line 176 is redundant because platform_get_irq() already prints an error
--- drivers/thermal/db8500_thermal.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-)
drivers/thermal/db8500_thermal.c +2 -6
@@ -158,10 +158,8 @@ static int db8500_thermal_probe(struct platform_device *pdev)return -ENOMEM ; low_irq =platform_get_irq_byname (pdev,"IRQ_HOTMON_LOW" ); -if (low_irq <0 ) { -dev_err (dev,"Get IRQ_HOTMON_LOW failed\n" ); +if (low_irq <0 )return low_irq; - } ret = devm_request_threaded_irq(dev, low_irq, NULL, prcmu_low_irq_handler, IRQF_NO_SUSPEND | IRQF_ONESHOT,
@@ -172,10 +170,8 @@ static int db8500_thermal_probe(struct platform_device *pdev) } high_irq =platform_get_irq_byname (pdev,"IRQ_HOTMON_HIGH" ); -if (high_irq <0 ) { -dev_err (dev,"Get IRQ_HOTMON_HIGH failed\n" ); +if (high_irq <0 )return high_irq; - } ret = devm_request_threaded_irq(dev, high_irq, NULL, prcmu_high_irq_handler, IRQF_NO_SUSPEND | IRQF_ONESHOT,
Signature · 1 line
2.20.1.7.g153144c
Daniel Lezcano
AppliedQuoted 9 lines · Yang Li
The print function
dev_err()is redundant becauseplatform_get_irq()already prints an error.Eliminate the follow coccicheck warnings:
./drivers/thermal/db8500_thermal.c:162:2-9: line 162 is redundant becauseplatform_get_irq()already prints an error ./drivers/thermal/db8500_thermal.c:176:2-9: line 176 is redundant becauseplatform_get_irq()already prints an errorSigned-off-by Yang Li <[email protected]>---
Applied, thanks
Signature · 5 lines
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog
The following commit has been merged into the thermal/next branch of thermal:
The following commit has been merged into the thermal/next branch of thermal:
Commit-ID: 8cf18eea46e24a337c5a095edeed42ca03e97811 Gitweb: https://git.kernel.org/pub/scm/linux/kernel/git/thermal/linux.git//8cf18eea46e24a337c5a095edeed42ca03e97811 Author: Yang Li <[email protected]> AuthorDate: Tue, 19 Jul 2022 08:35:56 +08:00 Committer: Daniel Lezcano <[email protected]> CommitterDate: Thu, 28 Jul 2022 17:29:50 +02:00
thermal/drivers/u8500: Remove unnecessary print function dev_err()
The print function dev_err() is redundant because platform_get_irq() already prints an error.
Eliminate the follow coccicheck warnings:
./drivers/thermal/db8500_thermal.c:162:2-9: line 162 is redundant because platform_get_irq() already prints an error ./drivers/thermal/db8500_thermal.c:176:2-9: line 176 is redundant because platform_get_irq() already prints an error
--- drivers/thermal/db8500_thermal.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-)
drivers/thermal/db8500_thermal.c +2 -6
@@ -158,10 +158,8 @@ static int db8500_thermal_probe(struct platform_device *pdev)return -ENOMEM ; low_irq =platform_get_irq_byname (pdev,"IRQ_HOTMON_LOW" ); -if (low_irq <0 ) { -dev_err (dev,"Get IRQ_HOTMON_LOW failed\n" ); +if (low_irq <0 )return low_irq; - } ret = devm_request_threaded_irq(dev, low_irq, NULL, prcmu_low_irq_handler, IRQF_NO_SUSPEND | IRQF_ONESHOT,
@@ -172,10 +170,8 @@ static int db8500_thermal_probe(struct platform_device *pdev) } high_irq =platform_get_irq_byname (pdev,"IRQ_HOTMON_HIGH" ); -if (high_irq <0 ) { -dev_err (dev,"Get IRQ_HOTMON_HIGH failed\n" ); +if (high_irq <0 )return high_irq; - } ret = devm_request_threaded_irq(dev, high_irq, NULL, prcmu_high_irq_handler, IRQF_NO_SUSPEND | IRQF_ONESHOT,