Skip to contentSkip to conversation

ARM: dts: BCM5301X: Enable USB 3 PHY on Luxul XWR-3150

PATCH Applied Rafał Miłecki 5 participants 7 messages Nov 13, 2020 – Nov 16, 2020 Device tree bindings

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: dts: BCM5301X: Enable USB 3 PHY on Luxul XWR-3150

From: Rafał Miłecki <[email protected]>

This device has a functional USB 3 port so PHY is required.

---
 arch/arm/boot/dts/bcm47094-luxul-xwr-3150-v1.dts | 4 ++++
 1 file changed, 4 insertions(+)
arch/arm/boot/dts/bcm47094-luxul-xwr-3150-v1.dts +4 -0
index 4d5c5aa7dc42..1a6b9f56d67a 100644
@@ -71,6 +71,10 @@ &usb3 {
 	vcc-gpio = <&chipcommon 18 GPIO_ACTIVE_HIGH>;
 };
 
+&usb3_phy {
+	status = "okay";
+}
+
 &spi_nor {
 	status = "okay";
 };
Signature · 1 line
2.27.0
#1 lore raw
I love your patch! Yet something to improve:

Hi "Rafał,

I love your patch! Yet something to improve:

[auto build test ERROR on robh/for-next]
[also build test ERROR on v5.10-rc3 next-20201113]
[If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Rafa-Mi-ecki/ARM-dts-BCM5301X-Enable-USB-3-PHY-on-Luxul-XWR-3150/20201113-175236
base:   https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
config: arm-randconfig-r036-20201113 (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0

reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/1f7742592f638fdb90b7270d80d0c797e243ada7
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Rafa-Mi-ecki/ARM-dts-BCM5301X-Enable-USB-3-PHY-on-Luxul-XWR-3150/20201113-175236 git checkout 1f7742592f638fdb90b7270d80d0c797e243ada7
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm

If you fix the issue, kindly add following tag as appropriate

All errors (new ones prefixed by >>):

>> Error: arch/arm/boot/dts/bcm47094-luxul-xwr-3150-v1.dts:78.1-9 syntax error

FATAL ERROR: Unable to parse input tree

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

#2 lore raw

Hey,

Quoted 27 lines · kernel test robot

[auto build test ERROR on robh/for-next]
[also build test ERROR on v5.10-rc3 next-20201113]
[If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:
https://github.com/0day-ci/linux/commits/Rafa-Mi-ecki/ARM-dts-BCM5301X-Enable-USB-3-PHY-on-Luxul-XWR-3150/20201113-175236
base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git
for-next
config: arm-randconfig-r036-20201113 (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross
-O ~/bin/make.cross
chmod +x ~/bin/make.cross
#
https://github.com/0day-ci/linux/commit/1f7742592f638fdb90b7270d80d0c797e243ada7
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review
Rafa-Mi-ecki/ARM-dts-BCM5301X-Enable-USB-3-PHY-on-Luxul-XWR-3150/20201113-175236
git checkout 1f7742592f638fdb90b7270d80d0c797e243ada7
# save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross
ARCH=arm

Quoted 8 lines

If you fix the issue, kindly add following tag as appropriate

All errors (new ones prefixed by >>):

Quoted 2 lines
Quoted 2 lines

Error: arch/arm/boot/dts/bcm47094-luxul-xwr-3150-v1.dts:78.1-9 syntax error

FATAL ERROR: Unable to parse input tree

Is there a problem with bot or GitHub? I can't access any:

https://github.com/0day-ci/linux/commits/Rafa-Mi-ecki/ARM-dts-BCM5301X-Enable-USB-3-PHY-on-Luxul-XWR-3150/20201113-175236
https://github.com/0day-ci/linux/commit/1f7742592f638fdb90b7270d80d0c797e243ada7

#3 lore raw
Quoted 40 lines · Rafał Miłecki

Hey,

Quoted 37 lines · kernel test robot

[auto build test ERROR on robh/for-next]
[also build test ERROR on v5.10-rc3 next-20201113]
[If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:
https://github.com/0day-ci/linux/commits/Rafa-Mi-ecki/ARM-dts-BCM5301X-Enable-USB-3-PHY-on-Luxul-XWR-3150/20201113-175236

base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git
for-next
config: arm-randconfig-r036-20201113 (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross
-O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        #
https://github.com/0day-ci/linux/commit/1f7742592f638fdb90b7270d80d0c797e243ada7

        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Rafa-Mi-ecki/ARM-dts-BCM5301X-Enable-USB-3-PHY-on-Luxul-XWR-3150/20201113-175236

        git checkout 1f7742592f638fdb90b7270d80d0c797e243ada7

        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 
make.cross ARCH=arm

If you fix the issue, kindly add following tag as appropriate

All errors (new ones prefixed by >>):

Quoted 2 lines
Quoted 2 lines

Error: arch/arm/boot/dts/bcm47094-luxul-xwr-3150-v1.dts:78.1-9 syntax error

Quoted 9 lines
Quoted 1 line

   FATAL ERROR: Unable to parse input tree

Is there a problem with bot or GitHub? I can't access any:

https://github.com/0day-ci/linux/commits/Rafa-Mi-ecki/ARM-dts-BCM5301X-Enable-USB-3-PHY-on-Luxul-XWR-3150/20201113-175236

https://github.com/0day-ci/linux/commit/1f7742592f638fdb90b7270d80d0c797e243ada7

Hi Rafał ,

The git push service was busy at that time and the branch has been uploaded to github at 2020-11-14 03:22:56 +0800.

Best Regards,
Rong Chen

#5 lore raw
Quoted 9 lines · Florian Fainelli
Quoted 6 lines · Rafał Miłecki

From: Rafał Miłecki <[email protected]>

This device has a functional USB 3 port so PHY is required.

---

Applied to devicetree/next, thanks!

After fixing it up so it builds:

(quoted diff) +0 -0

b/arch/arm/boot/dts/bcm47094-luxul-xwr-3150-v1.dts index 1a6b9f56d67a..a361aa8627d3 100644

arch/arm/boot/dts/bcm47094-luxul-xwr-3150-v1.dts +1 -1
@@ -73,7 +73,7 @@ &usb3 {
 
 &usb3_phy {
        status = "okay";
-}
+};
 
 &spi_nor {
        status = "okay";
Signature · 1 line
Florian
#6 lore raw
Quoted 6 lines · Florian Fainelli
Quoted 5 lines · Florian Fainelli
Quoted 4 lines · Rafał Miłecki

From: Rafał Miłecki <[email protected]>

This device has a functional USB 3 port so PHY is required.

Quoted 7 lines
Quoted 4 lines
Quoted 2 lines

---

Applied to devicetree/next, thanks!

After fixing it up so it builds:

Oops. Sorry and thanks!