Skip to contentSkip to conversation

libata-dev: recognize WRITE_MULTI_FUA_EXT for r/w multiple

PATCH In review Albert Lee 4 participants 4 messages Mar 3, 2006 libata

lore
Share & tools
lore

Albert Lee

author
#0 lore raw

PATCH 1/1 libata-dev: recognize WRITE_MULTI_FUA_EXT for r/w multiple

Jeff,

Changes:
Recognize ATA_CMD_WRITE_MULTI_FUA_EXT as r/w multiple commands.

Patch against the irq-pio branch
(1ed82ae3df3882bfcb5bfe5e9f97e4e8e23af299).

For your review, thanks.

Albert

---

include/linux/ata.h +2 -1
@@ -314,7 +314,8 @@ static inline int is_multi_taskfile(stru
 	return (tf->command == ATA_CMD_READ_MULTI) ||
 	       (tf->command == ATA_CMD_WRITE_MULTI) ||
 	       (tf->command == ATA_CMD_READ_MULTI_EXT) ||
-	       (tf->command == ATA_CMD_WRITE_MULTI_EXT);
+	       (tf->command == ATA_CMD_WRITE_MULTI_EXT) ||
+	       (tf->command == ATA_CMD_WRITE_MULTI_FUA_EXT);
 }
 
 static inline int ata_ok(u8 status)
#1 lore raw
Quoted 4 lines · Albert Lee

Jeff,

Changes:
Recognize ATA_CMD_WRITE_MULTI_FUA_EXT as r/w multiple commands.

This one will require exhaustive testing on various controllers. There are quite a few PIO boards with FIFOs that "recognize" opcodes for READs and WRITEs. And practically all of them predate any concept of FUA commands.

Very VERY risky.

#2 lore raw
Quoted 6 lines · Mark Lord
Quoted 4 lines · Albert Lee

Jeff,

Changes:
Recognize ATA_CMD_WRITE_MULTI_FUA_EXT as r/w multiple commands.

Quoted 6 lines

This one will require exhaustive testing on various controllers. There are quite a few PIO boards with FIFOs that "recognize" opcodes for READs and WRITEs. And practically all of them predate any concept of FUA commands.

Very VERY risky.

Which is why it's so annoying and seemingly idiotic that t13 keeps making up new opcodes for the exact same thing instead of allowing options bits.

Signature · 1 line
Jens Axboe
#3 lore raw
In reply to Albert Lee
Quoted 5 lines · Albert Lee

Jeff,

Changes:
Recognize ATA_CMD_WRITE_MULTI_FUA_EXT as r/w multiple commands.

Quoted 8 lines

Patch against the irq-pio branch
(1ed82ae3df3882bfcb5bfe5e9f97e4e8e23af299).

For your review, thanks.

Albert

I would request that you adjust your patch submission slightly. Stuff like "Jeff," "Changes:", "Patch against...", "For your review", "Albert" all must be hand-edited out before applying the patch. Everything before the "---" terminator is copied directly into the kernel changelog.

Take a look at Tejun's recent patches for an example. The message body of his emailed submissions look like:

	[change description]
	[signed-off-by]
	---
	[notes, comments, insults, etc.  :)]

include/linux/ata.h static inline int is_multi_taskfile(stru · line 318

Quoted 9 lines
include/linux/ata.h +2 -1
@@ -314,7 +314,8 @@ static inline int is_multi_taskfile(stru
 	return (tf->command == ATA_CMD_READ_MULTI) ||
 	       (tf->command == ATA_CMD_WRITE_MULTI) ||
 	       (tf->command == ATA_CMD_READ_MULTI_EXT) ||
-	       (tf->command == ATA_CMD_WRITE_MULTI_EXT);
+	       (tf->command == ATA_CMD_WRITE_MULTI_EXT) ||
+	       (tf->command == ATA_CMD_WRITE_MULTI_FUA_EXT);

Applied to irq-pio branch, though Mark Lord makes a correct point. We may have to create a whitelist for PATA devices that support FUA, rather than a blacklist. Something to think about...

Thanks,

Jeff