common: parse 'email (name)' correctly

PATCH New Sam Vilain 1 participant 1 message Jun 15, 2016

Share & tools

Sam Vilain

author

2016-06-15 22:42 UTC #0 lore raw

PATCH 1/1 common: parse 'email (name)' correctly

Currently only e-mails of the form "Name <email>" are accepted by stgit import etc, however some people use "email (Name)". Accept this alternate form.
---
Note: the function just below it might need consideration, too.

 stgit/commands/common.py |    7 +++++--
 1 files changed, 5 insertions(+), 2 deletions(-)

stgit/commands/common.py +4 -2

index 2985379..4bfa4dd 100644
@@ -175,12 +175,15 @@ def push_patches(patches, check_merged =
 
 def name_email(address):
     """Return a tuple consisting of the name and email parsed from a
-    standard 'name <email>' string
+    standard 'name <email>' or 'email (name)' string
     """
     address = re.sub('[\\\\"]', '\\\\\g<0>', address)
     str_list = re.findall('^(.*)\s*<(.*)>\s*$', address)
     if not str_list:
-        raise CmdException, 'Incorrect "name <email>" string: %s' % address
+        str_list = re.findall('^(.*)\s*\((.*)\)\s*$', address)
+        if not str_list:
+            raise CmdException, 'Incorrect "name <email>"/"email

(name)" string: %s' % address
+ return ( str_list[0][1], str_list[0][0] )

return str_list[0]