fix time ordering of writes to .kconfig.d and include/linux/autoconf.h
PATCH 1/1 fix time ordering of writes to .kconfig.d and include/linux/autoconf.h
Since .kconfig.d is used as a make dependency of include/linux/autoconf.h, it should be written earlier than the header file, to avoid a subsequent rebuild to consider the header outdated.
diff -Npru /home/jbeulich/tmp/linux-2.6.16-rc5/scripts/kconfig/confdata.c 2.6.16-rc5-kconfig_d-deps/scripts/kconfig/confdata.c
scripts/kconfig/confdata.c renamed from home/jbeulich/tmp/linux-2.6.16-rc5/scripts/kconfig/confdata.c +1 -1
@@ -374,6 +374,7 @@ int conf_write(const char *name) out_h =fopen (".tmpconfig.h" ,"w" );if (!out_h)return 1 ; +file_write_dep (NULL ); } sym =sym_lookup ("KERNELVERSION" ,0 );sym_calc_value (sym);
@@ -512,7 +513,6 @@ int conf_write(const char *name)if (out_h) {fclose (out_h);rename (".tmpconfig.h" ,"include/linux/autoconf.h" ); -file_write_dep (NULL ); }if (!name || basename != conf_def_filename) {if (!name)
Quoted 3 lines · Jan Beulich
Since .kconfig.d is used as a make dependency of
include/linux/autoconf.h, it should be written earlier than the header file, to avoid a subsequent rebuild to consider the header outdated.
Thanks Jan. I assume you saw this in reality?
Applied.
Sam
Quoted 7 lines
Quoted 1 line
Quoted 1 line
Sam Ravnborg <[email protected]> 12.03.06 23:43:28 >>>
Quoted 3 lines · Jan Beulich
Since .kconfig.d is used as a make dependency of
include/linux/autoconf.h, it should be written earlier than the header file, to avoid a subsequent rebuild to consider the header outdated.Thanks Jan. I assume you saw this in reality?
Yes, I did.
Quoted 1 line
Applied.
Thanks, Jan