Skip to contentSkip to conversation

question on what is ejectable?

DISCUSSION Kristen Accardi 3 participants 3 messages Mar 8, 2006 – Mar 14, 2006 ACPI

lore
Share & tools
lore
#0 lore raw

I notice in the acpi_bus_get_flags() function ejectable is defined as anything that has either _EJ0 or _EJD. However, the acpi pci hotplug driver defines an ejectable slot as being one which must have (among other things) _EJ0. Is it legitimate to change the definition of an ejectable slot to be one that has either _EJ0 or _EJD (in addition to the other requirements for pci hotplug slots).

Kristen

#1 lore raw
Quoted 7 lines · Kristen Accardi

I notice in the acpi_bus_get_flags() function ejectable is defined as anything that has either _EJ0 or _EJD. However, the acpi pci hotplug driver defines an ejectable slot as being one which must have (among other things) _EJ0. Is it legitimate to change the definition of an ejectable slot to be one that has either _EJ0 or _EJD (in addition to the other requirements for pci hotplug slots).

As the acpi_bus_get_flags() does, I think "ejectable device" is defined as anything that has either _EJ0 or _EJD. But I don't think the device is "ejectable slot" if it has _EJD but it doesn't have _EJ0. If an eject request was notified to such devices, I don't know how to eject those. I think one of the requirements for pci hotplug slots is having _EJ0.

Thanks,
Kenji Kaneshige

#2 lore raw

At Fri, 10 Mar 2006 11:28:58 +0900,

Quoted 10 lines · Kenji Kaneshige
Quoted 7 lines · Kristen Accardi

I notice in the acpi_bus_get_flags() function ejectable is defined as anything that has either _EJ0 or _EJD. However, the acpi pci hotplug driver defines an ejectable slot as being one which must have (among other things) _EJ0. Is it legitimate to change the definition of an ejectable slot to be one that has either _EJ0 or _EJD (in addition to the other requirements for pci hotplug slots).

Quoted 5 lines

As the acpi_bus_get_flags() does, I think "ejectable device" is defined as anything that has either _EJ0 or _EJD. But I don't think the device is "ejectable slot" if it has _EJD but it doesn't have _EJ0. If an eject request was notified to such devices, I don't know how to eject those. I think one of the requirements for pci hotplug slots is having _EJ0.

I agree with Kenji's opinion.
I also worry about that if an eject request is raised on the _EJD defined device.

Thank,
MUNE