Skip to contentSkip to conversation

savagefb: Fix kfree before use

PATCH In review Antonino A. Daplas 1 participant 1 message Mar 11, 2006 Framebuffer layer

lore
Share & tools
lore
#0 lore raw

PATCH 9/18 savagefb: Fix kfree before use

par->edid is kfree'd before using in fb_edid_to_monspecs()

---

 drivers/video/savage/savagefb_driver.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/video/savage/savagefb_driver.c +1 -1
index ab727ea..10e6b3a 100644
@@ -2021,8 +2021,8 @@ static int __devinit savagefb_probe (str
 #if defined(CONFIG_FB_SAVAGE_I2C)
 	savagefb_create_i2c_busses(info);
 	savagefb_probe_i2c_connector(info, &par->edid);
-	kfree(par->edid);
 	fb_edid_to_monspecs(par->edid, &info->monspecs);
+	kfree(par->edid);
 	fb_videomode_to_modelist(info->monspecs.modedb,
 				 info->monspecs.modedb_len,
 				 &info->modelist);

-------------------------------------------------------
This SF.Net email is sponsored by xPML, a groundbreaking scripting language that extends applications into web and mobile media. Attend the live webcast and join the prime developer group breaking into this new coding territory!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642