Skip to contentSkip to conversation

atyfb: Remove dead code

PATCH In review Antonino A. Daplas 2 participants 2 messages Mar 11, 2006 Framebuffer layer

lore
Share & tools
lore

Antonino A. Daplas

author
#0 lore raw

PATCH 16/18 atyfb: Remove dead code

Remove code that can never be reached.

Coverity Bug 67

Signed-off-by Antonino Daplas <[email protected]>

---

 drivers/video/aty/atyfb_base.c |    8 +++++---
 1 files changed, 5 insertions(+), 3 deletions(-)
drivers/video/aty/atyfb_base.c +5 -3
index 1a5c0f6..c69c336 100644
@@ -2298,6 +2298,10 @@ static int __init aty_init(struct fb_inf
 		case CLK_ATI18818_1:
 			par->pll_ops = &aty_pll_ati18818_1;
 			break;
+		case CLK_IBMRGB514:
+			par->pll_ops = &aty_pll_ibm514;
+			break;
+#if 0 /* dead code */
 		case CLK_STG1703:
 			par->pll_ops = &aty_pll_stg1703;
 			break;

@@ -2307,9 +2311,7 @@ static int __init aty_init(struct fb_inf
 		case CLK_ATT20C408:
 			par->pll_ops = &aty_pll_att20c408;
 			break;
-		case CLK_IBMRGB514:
-			par->pll_ops = &aty_pll_ibm514;
-			break;
+#endif
 		default:
 			PRINTKI("aty_init: CLK type not implemented yet!");
 			par->pll_ops = &aty_pll_unsupported;

-------------------------------------------------------
This SF.Net email is sponsored by xPML, a groundbreaking scripting language that extends applications into web and mobile media. Attend the live webcast and join the prime developer group breaking into this new coding territory!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642

Acked-by on v1 16/18
#1 lore raw

Am Samstag, 11. März 2006 02:51 schrieb Antonino A. Daplas:

Quoted 5 lines

Remove code that can never be reached.

Coverity Bug 67

Signed-off-by Antonino Daplas <[email protected]>
Acked-by Alexander Kern <[email protected]>
Quoted 31 lines

---

 drivers/video/aty/atyfb_base.c |    8 +++++---
 1 files changed, 5 insertions(+), 3 deletions(-)
(quoted diff) +0 -0

b/drivers/video/aty/atyfb_base.c index 1a5c0f6..c69c336 100644

drivers/video/aty/atyfb_base.c +5 -3
@@ -2298,6 +2298,10 @@ static int __init aty_init(struct fb_inf
 		case CLK_ATI18818_1:
 			par->pll_ops = &aty_pll_ati18818_1;
 			break;
+		case CLK_IBMRGB514:
+			par->pll_ops = &aty_pll_ibm514;
+			break;
+#if 0 /* dead code */
 		case CLK_STG1703:
 			par->pll_ops = &aty_pll_stg1703;
 			break;

@@ -2307,9 +2311,7 @@ static int __init aty_init(struct fb_inf
 		case CLK_ATT20C408:
 			par->pll_ops = &aty_pll_att20c408;
 			break;
-		case CLK_IBMRGB514:
-			par->pll_ops = &aty_pll_ibm514;
-			break;
+#endif
 		default:
 			PRINTKI("aty_init: CLK type not implemented yet!");
 			par->pll_ops = &aty_pll_unsupported;
Signature · 11 lines
Best Wishes
Mit freundlichen Grüßen

Alex Kern


-------------------------------------------------------
This SF.Net email is sponsored by xPML, a groundbreaking scripting language
that extends applications into web and mobile media. Attend the live webcast
and join the prime developer group breaking into this new coding territory!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid0944&bid$1720&dat1642