Skip to contentSkip to conversation

radeonfb: Fix static array overrun

PATCH New Antonino A. Daplas 1 participant 1 message Mar 11, 2006 Framebuffer layer

lore
Share & tools
lore
#0 lore raw

PATCH 18/18 radeonfb: Fix static array overrun

radeonfb_parse_monitor_layout() will produce an array overrun if passed with a substring of length higher than 4 (ie, "XXXXX,YYYYYY").

Coverity Bug 494

---

 drivers/video/aty/radeon_monitor.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)
drivers/video/aty/radeon_monitor.c +4 -0
index 7f9838d..98c05bc 100644
@@ -396,6 +396,10 @@ static int __devinit radeon_parse_monito
 				s1[i] = *s;
 			i++;
 		}
+
+		if (i > 4)
+			i = 4;
+
 	} while (*s++);
 	if (second)
 		s2[i] = 0;

-------------------------------------------------------
This SF.Net email is sponsored by xPML, a groundbreaking scripting language that extends applications into web and mobile media. Attend the live webcast and join the prime developer group breaking into this new coding territory!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642