Skip to contentSkip to conversation

libata-dev: add flush task to ata_exec_internal()

PATCH Applied Albert Lee 3 participants 5 messages Mar 14, 2006 – Mar 22, 2006

Subsystems (2)
SCSI libata
lore
Share & tools
lore

Albert Lee

author
#0 lore raw

PATCH 1/1 libata-dev: add flush task to ata_exec_internal()

Add ata_port_flush_task() to ata_exec_internal().

Signed-off-by Albert Lee <[email protected]>

---

It seems we also need ata_port_flush_task() in ata_exec_internal().

Patch against the upstream branch
(fb21f0d0ec7e31cc814165e1a9d2662d9c9dd980).

For your review, thanks,

Albert

drivers/scsi/libata-core.c +2 -0
@@ -962,6 +962,8 @@ ata_exec_internal(struct ata_port *ap, s
 	spin_unlock_irqrestore(&ap->host_set->lock, flags);
 
 	if (!wait_for_completion_timeout(&wait, ATA_TMOUT_INTERNAL)) {
+		ata_port_flush_task(ap);
+
 		spin_lock_irqsave(&ap->host_set->lock, flags);
 
 		/* We're racing with irq here.  If we lose, the
#1 lore raw
Quoted 18 lines · Albert Lee

Add ata_port_flush_task() to ata_exec_internal().

Signed-off-by Albert Lee <[email protected]>

---

It seems we also need ata_port_flush_task() in ata_exec_internal().

Patch against the upstream branch
(fb21f0d0ec7e31cc814165e1a9d2662d9c9dd980).

For your review, thanks,

Albert

drivers/scsi/libata-core.c ata_exec_internal(struct ata_port *ap, s · line 969

Quoted 8 lines
drivers/scsi/libata-core.c +2 -0
@@ -962,6 +962,8 @@ ata_exec_internal(struct ata_port *ap, s
 	spin_unlock_irqrestore(&ap->host_set->lock, flags);
 
 	if (!wait_for_completion_timeout(&wait, ATA_TMOUT_INTERNAL)) {
+		ata_port_flush_task(ap);
+
 		spin_lock_irqsave(&ap->host_set->lock, flags);
 
 		/* We're racing with irq here.  If we lose, the

Yes, we certainly need this. The irq handling isn't really correct either as irq handlers don't clear interrupt conditions on spurious interrupts. I hope/plan to address this during EH work.

Anyways, ACK.

Thanks.

Signature · 1 line
tejun
#2 lore raw
Quoted 1 line · Tejun Heo

Yes, we certainly need this. The irq handling isn't really correct either as irq handlers don't clear interrupt conditions on spurious interrupts. I hope/plan to address this during EH work.

Except for the HSM, there is no guaranteed way to know if an interrupt is spurious or not on many controllers, who lack an "I have an interrupt" bit.

Jeff

#3 lore raw
Quoted 7 lines · Jeff Garzik
Quoted 1 line · Tejun Heo

Yes, we certainly need this. The irq handling isn't really correct either as irq handlers don't clear interrupt conditions on spurious interrupts. I hope/plan to address this during EH work.

Except for the HSM, there is no guaranteed way to know if an interrupt is spurious or not on many controllers, who lack an "I have an interrupt" bit.

What I'm thinking is to disable interrupt (hopefully using controller flag, maybe PCI IRQ disable, ATA_NIEN if nothing else is possible) on error condition which may breach HSM and force controller and device to a known state in ->error_handler() or ->post_internal_command() before reenabling interrupt. This method will also make libata resistant to screaming IRQ cases some controllers/drives show under certain circumstances.

And I think clearing ->hsm_task_state belongs to (to-be-added) ->post_internal_command() as it belongs to ->eng_timeout but not to EH framework.

Thanks.

Signature · 1 line
tejun