Skip to contentSkip to conversation

perf patches needed for 4.19 stable

DISCUSSION Rolf Eike Beer 1 participant 1 message Sep 13, 2022

lore
Share & tools
lore
#0 lore raw

Greetings,

I had to compile perf for a 4.19 kernel with gcc 10.4 and glibc 2.36. It failed because some patches seem to be missing there.

I have identified these 2 at least:

ebcb9464a2ae3a547e97de476575c82ece0e93e2 perf env: Do not return pointers to local variables

d08c84e01afa7a7eee6badab25d5420fa847f783
perf sched: Cast PTHREAD_STACK_MIN to int as it may turn into sysconf(__SC_THREAD_STACK_MIN_VALUE)

The former was introduced in 5.7, the latter in 5.14, so backports to 5.4 and 5.10 may also be missing.

At the end the build still has failed because of this:

In file included from /opt/emlix/master/sysroot/usr/include/stdio.h:906,

                 from /tmp/e2/build/linux-4.19.254/tools/lib/traceevent/event-

parse.h:25,
from util/session.c:5:
In function 'printf',
inlined from 'regs_dump__printf' at util/session.c:968:3, inlined from 'regs__printf' at util/session.c:996:2:
/opt/emlix/master/sysroot/usr/include/bits/stdio2.h:86:10: warning: '%-5s' directive argument is null [-Wformat-overflow=]
86 | return __printf_chk (__USE_FORTIFY_LEVEL - 1, __fmt, __va_arg_pack
());

I was not able to identify a patch for that, so I went with WERROR=0, but maybe someone knows how to get that fixed as well.

If you agree that these should be added to stable please either send them there or tell me to do so.

Regards,

Eike

Signature · 7 lines
Rolf Eike Beer, emlix GmbH, https://www.emlix.com
Fon +49 551 30664-0, Fax +49 551 30664-11
Gothaer Platz 3, 37083 Göttingen, Germany
Sitz der Gesellschaft: Göttingen, Amtsgericht Göttingen HR B 3160
Geschäftsführung: Heike Jordan, Dr. Uwe Kracke – Ust-IdNr.: DE 205 198 055

emlix - smart embedded open source