paz00 updates for 3.4

PATCH In review Marc Dietrich 3 participants 15 messages Jan 28, 2012 – Feb 1, 2012 5 messages not in the archive

Subsystems (4)

Device tree bindings Arm (32-bit) Arm sub-architectures Tegra architecture support

lore

Share & tools

lore

Marc Dietrich

author

2012-01-28 19:03 UTC #0 lore raw

cover paz00 updates for 3.4

The first two patches contain non-critical bug fixes (wrong power gpio and wrong uart port). The last three patches add the temperature sensor, the power gpio, and the wifi led to the device tree.

What's missing (after sound has been added) is rfkill and usb-utmi support. Is anyone planing to add DT support to these drivers? If not, I will try my best (you have been warned).

Marc Dietrich (5):
ARM: tegra: paz00: fix wrong SD1 power gpio
ARM: tegra: paz00: fix wrong UART port on mini-pcie plug
ARM: dt: tegra: add ADT7461 temperature sensor to paz00 device tree
ARM: dt: tegra: add the power gpio key to paz00 device tree
ARM: dt: tegra: add the wifi led to paz00 device tree

 arch/arm/boot/dts/tegra-paz00.dts |   32 +++++++++++++++++++++++++++++---
 arch/arm/mach-tegra/board-paz00.c |    8 ++++----
 arch/arm/mach-tegra/board-paz00.h |    2 +-
 3 files changed, 34 insertions(+), 8 deletions(-)

Signature · 1 line

1.7.5.4

A message that is not in the archive (sent off-list or not yet received): [email protected]

Marc Dietrich

author

2012-01-28 19:03 UTC #2 lore raw

PATCH 1/5 ARM: tegra: paz00: fix wrong SD1 power gpio

The power gpio for the external memory card was specified wrongly. Replace it with the correct value (tested with warmboot with fastboot).

Signed-off-by Marc Dietrich <[email protected]>

---
 arch/arm/boot/dts/tegra-paz00.dts |    2 +-
 arch/arm/mach-tegra/board-paz00.h |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

arch/arm/boot/dts/tegra-paz00.dts +1 -1

index 4d1bcdc..1e08934 100644
@@ -72,7 +72,7 @@
 	sdhci@c8000000 {
 		cd-gpios = <&gpio 173 0>; /* gpio PV5 */
 		wp-gpios = <&gpio 57 0>;  /* gpio PH1 */
-		power-gpios = <&gpio 155 0>; /* gpio PT3 */
+		power-gpios = <&gpio 169 0>; /* gpio PV1 */
 	};
 
 	sdhci@c8000200 {

arch/arm/mach-tegra/board-paz00.h +1 -1

index ffa83f5..3c9f8da 100644
@@ -22,7 +22,7 @@
 /* SDCARD */
 #define TEGRA_GPIO_SD1_CD		TEGRA_GPIO_PV5
 #define TEGRA_GPIO_SD1_WP		TEGRA_GPIO_PH1
-#define TEGRA_GPIO_SD1_POWER		TEGRA_GPIO_PT3
+#define TEGRA_GPIO_SD1_POWER		TEGRA_GPIO_PV1
 
 /* ULPI */
 #define TEGRA_ULPI_RST			TEGRA_GPIO_PV0

Signature · 1 line

1.7.5.4

Marc Dietrich

author

2012-01-28 19:03 UTC #3 lore raw

PATCH 2/5 ARM: tegra: paz00: fix wrong UART port on mini-pcie plug

In reply to a message not in the archive

UARTC is connected to the mini-pcie port.

Signed-off-by Marc Dietrich <[email protected]>

---
 arch/arm/boot/dts/tegra-paz00.dts |    4 ++--
 arch/arm/mach-tegra/board-paz00.c |    8 ++++----
 2 files changed, 6 insertions(+), 6 deletions(-)

arch/arm/boot/dts/tegra-paz00.dts +2 -2

index 1e08934..f667343 100644
@@ -58,11 +58,11 @@
 	};
 
 	serial@70006200 {
-		status = "disable";
+		clock-frequency = <216000000>;
 	};
 
 	serial@70006300 {
-		clock-frequency = <216000000>;
+		status = "disable";
 	};
 
 	serial@70006400 {

arch/arm/mach-tegra/board-paz00.c +4 -4

index fcf4f37..330afdf 100644
@@ -60,9 +60,9 @@ static struct plat_serial8250_port debug_uart_platform_data[] = {
 		.uartclk	= 216000000,
 	}, {
 		/* serial port on mini-pcie */
-		.membase	= IO_ADDRESS(TEGRA_UARTD_BASE),
-		.mapbase	= TEGRA_UARTD_BASE,
-		.irq		= INT_UARTD,
+		.membase	= IO_ADDRESS(TEGRA_UARTC_BASE),
+		.mapbase	= TEGRA_UARTC_BASE,
+		.irq		= INT_UARTC,
 		.flags		= UPF_BOOT_AUTOCONF | UPF_FIXED_TYPE,
 		.type		= PORT_TEGRA,
 		.iotype		= UPIO_MEM,

@@ -174,7 +174,7 @@ static void __init tegra_paz00_fixup(struct tag *tags, char **cmdline,
 static __initdata struct tegra_clk_init_table paz00_clk_init_table[] = {
 	/* name		parent		rate		enabled */
 	{ "uarta",	"pll_p",	216000000,	true },
-	{ "uartd",	"pll_p",	216000000,	true },
+	{ "uartc",	"pll_p",	216000000,	true },
 
 	{ "pll_p_out4",	"pll_p",	24000000,	true },
 	{ "usbd",	"clk_m",	12000000,	false },

Signature · 1 line

1.7.5.4

Marc Dietrich

author

2012-01-28 19:03 UTC #4 lore raw

PATCH 3/5 ARM: dt: tegra: add ADT7461 temperature sensor to paz00 device tree

In reply to a message not in the archive

Add the ADT7461 temperature monitoring IC which is connected via the DVC controller.

Signed-off-by Marc Dietrich <[email protected]>

---
 arch/arm/boot/dts/tegra-paz00.dts |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)

arch/arm/boot/dts/tegra-paz00.dts +5 -0

index f667343..f03ca40 100644
@@ -35,6 +35,11 @@
 
 	i2c@7000d000 {
 		clock-frequency = <400000>;
+
+		adt7461@4c {
+			compatible = "adt7461";
+			reg = <0x4c>;
+		};
 	};
 
 	i2s@70002800 {

Signature · 1 line

1.7.5.4

A message that is not in the archive (sent off-list or not yet received): 58e24ac63a8388bb9de6be0e75cea26a1af99195.1327776641.git.marvin24-Mmb7MZpHnFY@public.gmane.org

Stephen Warren

2012-01-30 17:26 UTC #6 lore raw

RE: [PATCH 3/5] ARM: dt: tegra: add ADT7461 temperature sensor to paz00 device tree

Marc Dietrich wrote at Saturday, January 28, 2012 12:03 PM:

arch/arm/boot/dts/tegra-paz00.dts line 40

Quoted 7 lines

Add the ADT7461 temperature monitoring IC which is connected via the DVC controller.
arch/arm/boot/dts/tegra-paz00.dts +2 -0
 
+		adt7461@4c {
+			compatible = "adt7461";

Compatible should have a vendor prefix, so "adi,adt7461".

Signature · 1 line

nvpublic

A message that is not in the archive (sent off-list or not yet received): 74CDBE0F657A3D45AFBB94109FB122FF178E12414D-C7FfzLzN0UxDw2glCA4ptUEOCMrvLtNR@public.gmane.org

Marc Dietrich

author

2012-01-31 11:48 UTC #8 lore raw

Re: RE: [PATCH 3/5] ARM: dt: tegra: add ADT7461 temperature sensor topaz00 device tree

Am Montag, 30. Januar 2012, 09:26:47 schrieb Stephen Warren:

Quoted 11 lines

Marc Dietrich wrote at Saturday, January 28, 2012 12:03 PM:
arch/arm/boot/dts/tegra-paz00.dts line 40
Quoted 8 lines
Add the ADT7461 temperature monitoring IC which is connected via the DVC controller.
arch/arm/boot/dts/tegra-paz00.dts +2 -0
 
+		adt7461@4c {
+			compatible = "adt7461";
Compatible should have a vendor prefix, so "adi,adt7461".

you are right, that's the problem when just copy-n-paste from seaboard. On the other hand, I wonder why this worked at all, because lm90 does not contain an of_match_table yet. Is there also some "hidden" DT->platfrom_data conversion?

grep adi arch/*/boot/dts/ shows the PowerPC people are also using "adi,...". I'll send an update of the series with the correction and Acked-By.

Thanks

Marc

Stephen Warren

2012-01-31 17:27 UTC #9 lore raw

RE: RE: [PATCH 3/5] ARM: dt: tegra: add ADT7461 temperature sensor topaz00 device tree

Marc Dietrich wrote at Tuesday, January 31, 2012 4:49 AM:

Quoted 8 lines

Am Montag, 30. Januar 2012, 09:26:47 schrieb Stephen Warren:
Quoted 7 lines
Marc Dietrich wrote at Saturday, January 28, 2012 12:03 PM:
Quoted 6 lines
Add the ADT7461 temperature monitoring IC which is connected via the DVC controller.
arch/arm/boot/dts/tegra-paz00.dts +0 -0

Quoted 8 lines

Quoted 4 lines
arch/arm/boot/dts/tegra-paz00.dts line 40
Quoted 2 lines
arch/arm/boot/dts/tegra-paz00.dts +2 -0
+		adt7461@4c {
+			compatible = "adt7461";
Compatible should have a vendor prefix, so "adi,adt7461".
you are right, that's the problem when just copy-n-paste from seaboard. On the other hand, I wonder why this worked at all, because lm90 does not contain an of_match_table yet. Is there also some "hidden" DT->platfrom_data conversion?

I2C drivers can bind in two ways:

1) Direct use of an of_match_table.

2) Use of the i2c_device_id table. In this case, the I2C or OF core strips the vendor prefix (if any) from the compatible value, and checks it against all the entries in i2c_driver.id_table.

The latter is how your patch worked.

Signature · 1 line

nvpublic

A message that is not in the archive (sent off-list or not yet received): 74CDBE0F657A3D45AFBB94109FB122FF178E124426-C7FfzLzN0UxDw2glCA4ptUEOCMrvLtNR@public.gmane.org

Marc Dietrich

author

2012-01-31 18:55 UTC #11 lore raw

Re: [PATCH 3/5] ARM: dt: tegra: add ADT7461 temperature sensortopaz00 device tree

Hi Stephen,

Quoted 20 lines · On Tuesday 31 January 2012 09:27:17 Stephen Warren wrote:

Marc Dietrich wrote at Tuesday, January 31, 2012 4:49 AM:
Quoted 13 lines
Am Montag, 30. Januar 2012, 09:26:47 schrieb Stephen Warren:
Quoted 11 lines
Marc Dietrich wrote at Saturday, January 28, 2012 12:03 PM:
arch/arm/boot/dts/tegra-paz00.dts
Quoted 8 lines
Add the ADT7461 temperature monitoring IC which is connected via the DVC controller.
arch/arm/boot/dts/tegra-paz00.dts +2 -0
 
+		adt7461@4c {
+			compatible = "adt7461";
Compatible should have a vendor prefix, so "adi,adt7461".
Quoted 4 lines
you are right, that's the problem when just copy-n-paste from seaboard. On the other hand, I wonder why this worked at all, because lm90 does not contain an of_match_table yet. Is there also some "hidden" DT->platfrom_data conversion?
I2C drivers can bind in two ways:

Quoted 7 lines

1) Direct use of an of_match_table.
2) Use of the i2c_device_id table. In this case, the I2C or OF core strips the vendor prefix (if any) from the compatible value, and checks it against all the entries in i2c_driver.id_table.
The latter is how your patch worked.

ah, thanks for the explanation.

Marc

Marc Dietrich

author

2012-01-31 18:53 UTC #12 lore raw

PATCH v2 3/5 ARM: dt: tegra: add ADT7461 temperature sensor to paz00 device tree

In reply to a message not in the archive

Add the ADT7461 temperature monitoring IC which is connected via the DVC controller.

Signed-off-by Marc Dietrich <[email protected]>

---
 arch/arm/boot/dts/tegra-paz00.dts |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)

arch/arm/boot/dts/tegra- renamed from arch/arm/boot/dts/tegra-paz00.dts +0 -0

paz00.dts
index f667343..81e1d30 100644

arch/arm/boot/dts/tegra-paz00.dts +5 -0

@@ -35,6 +35,11 @@
 
        i2c@7000d000 {
                clock-frequency = <400000>;
+
+               adt7461@4c {
+                       compatible = "adi,adt7461";
+                       reg = <0x4c>;
+               };
        };
 
        i2s@70002800 {

Signature · 1 line

1.7.5.4

Stephen Warren

Acked-by on v2 3/5

2012-01-31 19:55 UTC #13 lore raw

RE: [PATCH v2 3/5] ARM: dt: tegra: add ADT7461 temperature sensor to paz00 device tree

Marc Dietrich wrote at Tuesday, January 31, 2012 11:53 AM:

Quoted 4 lines

Add the ADT7461 temperature monitoring IC which is connected via the DVC controller.
Signed-off-by Marc Dietrich <[email protected]>

Acked-by Stephen Warren <[email protected]>

Signature · 1 line

nvpublic

Olof Johansson

2012-02-01 08:26 UTC #14 lore raw

Re: [PATCH v2 3/5] ARM: dt: tegra: add ADT7461 temperature sensor to paz00 device tree

In reply to Marc Dietrich

Quoted 14 lines · Marc Dietrich

Add the ADT7461 temperature monitoring IC which is connected via the DVC controller.
Signed-off-by Marc Dietrich <[email protected]>
---
 arch/arm/boot/dts/tegra-paz00.dts |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)
arch/arm/boot/dts/tegra- renamed from arch/arm/boot/dts/tegra-paz00.dts +0 -0
paz00.dts
index f667343..81e1d30 100644

arch/arm/boot/dts/tegra-paz00.dts line 42

Quoted 8 lines

arch/arm/boot/dts/tegra-paz00.dts +5 -0

@@ -35,6 +35,11 @@
 
        i2c@7000d000 {
                clock-frequency = <400000>;
+
+               adt7461@4c {
+                       compatible = "adi,adt7461";
+                       reg = <0x4c>;
+               };

It's common to name the device node temp-sensor (or temperature-sensor) instead of the model of the actual chip. The name isn't significant for the binding, but it's a practice that's been used on other platforms for a long time.

I'll just fix it up when applying, if ok with you. No need to respin just for this.

-Olof

A message that is not in the archive (sent off-list or not yet received): [email protected]

Marc Dietrich

author

2012-02-01 09:41 UTC #16 lore raw

Re: Re: [PATCH v2 3/5] ARM: dt: tegra: add ADT7461 temperature sensor topaz00 device tree

Am Mittwoch, 1. Februar 2012, 00:26:04 schrieb Olof Johansson:

Quoted 31 lines · Marc Dietrich

Quoted 15 lines
Add the ADT7461 temperature monitoring IC which is connected via the DVC controller.
Signed-off-by Marc Dietrich <[email protected]>
---
 arch/arm/boot/dts/tegra-paz00.dts |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)
arch/arm/boot/dts/tegra- renamed from arch/arm/boot/dts/tegra-paz00.dts +0 -0
paz00.dts
index f667343..81e1d30 100644
arch/arm/boot/dts/tegra-paz00.dts line 44
Quoted 10 lines
arch/arm/boot/dts/tegra-paz00.dts +5 -0
@@ -35,6 +35,11 @@
 
        i2c@7000d000 {
 
                clock-frequency = <400000>;
 
+
+               adt7461@4c {
+                       compatible = "adi,adt7461";
+                       reg = <0x4c>;
+               };
It's common to name the device node temp-sensor (or temperature-sensor) instead of the model of the actual chip. The name isn't significant for the binding, but it's a practice that's been used on other platforms for a long time.

Quoted 2 lines

I'll just fix it up when applying, if ok with you. No need to respin just for this.

Renaming it to something like "temp-sensor" is also ok for me. Feel free to change this.

Thanks!

Marc

Marc Dietrich

author

2012-01-28 19:03 UTC #17 lore raw

PATCH 4/5 ARM: dt: tegra: add the power gpio key to paz00 device tree

In reply to a message not in the archive

This adds the wakeup gpio which is connected to the embedded controller to the device tree of paz00.

Signed-off-by Marc Dietrich <[email protected]>

---
 arch/arm/boot/dts/tegra-paz00.dts |   11 +++++++++++
 1 files changed, 11 insertions(+), 0 deletions(-)

arch/arm/boot/dts/tegra-paz00.dts +11 -0

index f03ca40..2a16ff0 100644
@@ -91,4 +91,15 @@
 	sdhci@c8000600 {
 		support-8bit;
 	};
+
+	gpio-keys {
+		compatible = "gpio-keys";
+
+		power {
+			label = "Power";
+			gpios = <&gpio 79 1>; /* gpio PJ7, active low */
+			linux,code = <116>; /* KEY_POWER */
+			gpio-key,wakeup;
+		};
+	};
 };

Signature · 1 line

1.7.5.4

Marc Dietrich

author

2012-01-28 19:03 UTC #18 lore raw

PATCH 5/5 ARM: dt: tegra: add the wifi led to paz00 device tree

In reply to a message not in the archive

This adds the wifi led bound to the rfkill0 event to the device tree of paz00.

Signed-off-by Marc Dietrich <[email protected]>

---
 arch/arm/boot/dts/tegra-paz00.dts |   10 ++++++++++
 1 files changed, 10 insertions(+), 0 deletions(-)

arch/arm/boot/dts/tegra-paz00.dts +10 -0

index 2a16ff0..31c2d08 100644
@@ -102,4 +102,14 @@
 			gpio-key,wakeup;
 		};
 	};
+
+	gpio-leds {
+		compatible = "gpio-leds";
+
+		wifi {
+			label = "wifi-led";
+			gpios = <&gpio 24 0>;
+			linux,default-trigger = "rfkill0";
+		};
+	};
 };

Signature · 1 line

1.7.5.4

Stephen Warren

Acked-by

2012-01-30 17:28 UTC #19 lore raw

In reply to a message not in the archive

Marc Dietrich wrote at Saturday, January 28, 2012 12:03 PM:
...

Quoted 6 lines

Marc Dietrich (5):
ARM: tegra: paz00: fix wrong SD1 power gpio
ARM: tegra: paz00: fix wrong UART port on mini-pcie plug
ARM: dt: tegra: add ADT7461 temperature sensor to paz00 device tree
ARM: dt: tegra: add the power gpio key to paz00 device tree
ARM: dt: tegra: add the wifi led to paz00 device tree

Aside from the one comment I made, the series:

Acked-by Stephen Warren <[email protected]>

Signature · 1 line

nvpublic