Skip to contentSkip to conversation

remove dummy 1.2.3.4 IP

PATCH In review Charles Coffing 2 participants 2 messages Mar 30, 2006 – Mar 31, 2006

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 remove dummy 1.2.3.4 IP

Is there any good reason that a dummy NFS IP address of "1.2.3.4" is added to the domU kernel's boot line (in tools/python/xen/xm/create.py)?

In the past, I've seen cases where my domU would hang while the kernel was initializing its networking. Once I removed this dummy IP (as per the attached patch), things came up fine.

tools/python/xen/xm/create.py +1 -2
Index: xen-unstable/tools/python/xen/xm/create.py
===================================================================
@@ -709,9 +709,8 @@ def preprocess_vtpm(vals):
 
 def preprocess_ip(vals):
     if vals.ip or vals.dhcp != 'off':
-        dummy_nfs_server = '1.2.3.4'
         ip = (vals.ip
-          + ':' + (vals.nfs_server or dummy_nfs_server)
+          + ':' + (vals.nfs_server or '')
           + ':' + vals.gateway
           + ':' + vals.netmask
           + ':' + vals.hostname

_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xensource.com/xen-devel

#1 lore raw
Quoted 3 lines · Charles Coffing

Is there any good reason that a dummy NFS IP address of "1.2.3.4" is added to the domU kernel's boot line (in tools/python/xen/xm/create.py)?

Yes, otherwise kernel IP autoconfiguration doesn't/didn't work. Might have been on 2.4 only though...

christian