Skip to contentSkip to conversation

fix kbuild warning in pm2fb.o

PATCH In review Andrew Morton 2 participants 2 messages Apr 4, 2006 Framebuffer layer

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fix kbuild warning in pm2fb.o

Maybe pm2fb_set_par() should be __devinit?

Begin forwarded message:

Date: Mon, 03 Apr 2006 20:27:36 +1000
From: "Darren Jenkins\\" <[email protected]>
To: kernel Janitors <[email protected]>
Cc: LKML <[email protected]>
Subject: [KJ][Patch] fix kbuild warning in pm2fb.o

G'day list

There are a couple of Section mismatch problems in drivers/video/pm2fb.o

WARNING: drivers/video/pm2fb.o - Section mismatch: reference to .init.data: from .text after 'pm2fb_set_par' (at offset 0xd5d)
WARNING: drivers/video/pm2fb.o - Section mismatch: reference to .init.data: from .text after 'pm2fb_set_par' (at offset 0xd82)

They are caused because pm2fb_set_par() uses lowhsync and lowvsync which are marked __devinitdata.

The patch below simply removes the __devinitdata annotations.

drivers/video/pm2fb.c renamed from drivers/video/pm2fb.c.orig +2 -2
@@ -73,8 +73,8 @@ static char *mode __devinitdata = NULL;
  * these flags allow the user to specify that requests for +ve sync
  * should be silently turned in -ve sync.
  */
-static int lowhsync __devinitdata = 0;
-static int lowvsync __devinitdata = 0;
+static int lowhsync = 0;
+static int lowvsync = 0;
 
 /*
  * The hardware state of the graphics card that isn't part of the

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

-------------------------------------------------------
This SF.Net email is sponsored by xPML, a groundbreaking scripting language that extends applications into web and mobile media. Attend the live webcast and join the prime developer group breaking into this new coding territory!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642

#1 lore raw
Quoted 1 line · Andrew Morton

Maybe pm2fb_set_par() should be __devinit?

No, Darren's patch is correct.

Tony

-------------------------------------------------------
This SF.Net email is sponsored by xPML, a groundbreaking scripting language that extends applications into web and mobile media. Attend the live webcast and join the prime developer group breaking into this new coding territory!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642